tree 9192538f03b1b274e6ee91c63402929f7680f4ab
parent f33192437e5a4765cf0cb86092f0741d7d99df39
author Danny Tuppeny <danny@tuppeny.com> 1732217404 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> 1732217404 +0000

[analysis_server] Provide better values for active parameters in signature help

We were previously using a -1 because we don't support this, but it turns out the LSP spec changed from "number" to "uinteger" in v3.16, meaning -1 would violate some assumptions clients made.

For the case where we don't have a value, we now just use the `length` of the `parameters` list (eg. the first invalid value, which is valid according to the spec and can indicate to the client that there is no active parameter*), however I thought we could also do better by providing values for some cases (named params that we can match up, and positional params by counting only the positional params+args and matching them up).

\* The spec says clients can treat out-of-range values as 0, however VS Code doesn't highlight any parameters in that case, which is better IMO.

Fixes https://github.com/dart-lang/sdk/issues/58577

Change-Id: I1de7b0eaacf06aac7e302ae9095342f4e4d7a466
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>