)]}'
{
  "commit": "5681cfa6952e63b1bf93204d399dce7e545f2a73",
  "tree": "9192538f03b1b274e6ee91c63402929f7680f4ab",
  "parents": [
    "f33192437e5a4765cf0cb86092f0741d7d99df39"
  ],
  "author": {
    "name": "Danny Tuppeny",
    "email": "danny@tuppeny.com",
    "time": "Thu Nov 21 19:30:04 2024 +0000"
  },
  "committer": {
    "name": "Commit Queue",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Nov 21 19:30:04 2024 +0000"
  },
  "message": "[analysis_server] Provide better values for active parameters in signature help\n\nWe were previously using a -1 because we don\u0027t support this, but it turns out the LSP spec changed from \"number\" to \"uinteger\" in v3.16, meaning -1 would violate some assumptions clients made.\n\nFor the case where we don\u0027t have a value, we now just use the `length` of the `parameters` list (eg. the first invalid value, which is valid according to the spec and can indicate to the client that there is no active parameter*), however I thought we could also do better by providing values for some cases (named params that we can match up, and positional params by counting only the positional params+args and matching them up).\n\n\\* The spec says clients can treat out-of-range values as 0, however VS Code doesn\u0027t highlight any parameters in that case, which is better IMO.\n\nFixes https://github.com/dart-lang/sdk/issues/58577\n\nChange-Id: I1de7b0eaacf06aac7e302ae9095342f4e4d7a466\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/396840\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nCommit-Queue: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a00471895bee57e79558e13df5f1820c14507186",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/cider/signature_help.dart",
      "new_id": "b39b83d011ee6088b4aa4135015a01522f4db463",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/cider/signature_help.dart"
    },
    {
      "type": "modify",
      "old_id": "d7530353692b5f2cdbb87c7c795d2ec10dae24b1",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/computer/computer_signature.dart",
      "new_id": "ef0a88a35e56a69f5452225c54be13796c01aa8b",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/computer/computer_signature.dart"
    },
    {
      "type": "modify",
      "old_id": "6a9bccc131fecb97c8b3108e169af124941f446c",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/computer/computer_type_arguments_signature.dart",
      "new_id": "846504d9b08a31d7e4b89e586afc274d7315af56",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/computer/computer_type_arguments_signature.dart"
    },
    {
      "type": "modify",
      "old_id": "e0ddb0451deff69033073aa373edf20f4b5b1e86",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/handler/legacy/analysis_get_signature.dart",
      "new_id": "a19c340fd1cd09b1c343a7fd397a363d171d7452",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/handler/legacy/analysis_get_signature.dart"
    },
    {
      "type": "modify",
      "old_id": "64b1bb2092687d2c473fa60b34b91e423e541ef7",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/lsp/handlers/handler_signature_help.dart",
      "new_id": "50a2fe6d93559156d547008720a162f86b407f92",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/lsp/handlers/handler_signature_help.dart"
    },
    {
      "type": "modify",
      "old_id": "a99b8e0d8aa18124a3f20919927667c3d7991c8d",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/lsp/mapping.dart",
      "new_id": "63cb767b9887015b90fadca7a7eeae0cc18c4d43",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/lsp/mapping.dart"
    },
    {
      "type": "modify",
      "old_id": "796f330cef5c968205e9b91c80882b3eaa7bc912",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/signature_help_test.dart",
      "new_id": "17570577a88d30f6fb54683a9267272d9c5b169b",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/signature_help_test.dart"
    }
  ]
}