)]}'
{
  "commit": "5662ce3813cc4372a22dcea91d76aed549997fc5",
  "tree": "21d2b5d6d57b69d57936c1c51fc050232ed38267",
  "parents": [
    "34e7f575d681992f96987491343e048db6c7d9bc"
  ],
  "author": {
    "name": "Paul Berry",
    "email": "paulberry@google.com",
    "time": "Tue Apr 20 18:46:38 2021 +0000"
  },
  "committer": {
    "name": "commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Tue Apr 20 18:46:38 2021 +0000"
  },
  "message": "Add test runner support for context messages without location information.\n\nThe CFE implementation of \"why not promoted\" functionality for\nnon-promotion of `this` doesn\u0027t associate the context message with any\nlocation information, because there is no relevant location to cite.\nFor example, the output can look like this:\n\n    tests/language/why_not_promoted/this_error_test.dart:16:10: Error: Property \u0027isEven\u0027 cannot be accessed on \u0027int?\u0027 because it is potentially null.\n    Try accessing using ?. instead.\n        this.isEven;\n             ^^^^^^\n    Context: \u0027this\u0027 can\u0027t be promoted.\n    See http://dart.dev/go/non-promo-this\n\nThe test runner assumes that all messages have a location, so it\nwasn\u0027t picking up on this context message at all.  This CL avoids the\nproblem by having the test runner associate any location-less context\nmessage with the error above it.\n\n(Note that the analyzer doesn\u0027t have this problem; all of its context\nmessages have locations).\n\nChange-Id: Ied52daa8b0090f28617e7d3784233aa44dcc897a\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/195301\nReviewed-by: Bob Nystrom \u003crnystrom@google.com\u003e\nCommit-Queue: Paul Berry \u003cpaulberry@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5d8e49094291c4a850e41260dfb0aa8860779cf9",
      "old_mode": 33188,
      "old_path": "pkg/test_runner/lib/src/command_output.dart",
      "new_id": "779325c5656e448a2146c43e24296837457154df",
      "new_mode": 33188,
      "new_path": "pkg/test_runner/lib/src/command_output.dart"
    },
    {
      "type": "modify",
      "old_id": "2d836eec228e1a3092cccece2a1b11c552b74dea",
      "old_mode": 33188,
      "old_path": "tests/language/why_not_promoted/this_error_test.dart",
      "new_id": "87d98c98e1fe445b26b93288098a99318f6c2c36",
      "new_mode": 33188,
      "new_path": "tests/language/why_not_promoted/this_error_test.dart"
    }
  ]
}
