| commit | 8db293ed70ecdcc9d1f57e2be7297b3b2fba0232 | [log] [tgz] |
|---|---|---|
| author | Jens Johansen <jensj@google.com> | Fri Nov 30 12:39:27 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Fri Nov 30 12:39:27 2018 +0000 |
| tree | daac470a7a4a6fe85d239571959a2355963e3e32 | |
| parent | c45abca64887e6b3784950cc4e972d16858666e3 [diff] |
Lazy VariableIndexer in ast_to_binary.dart Often a VariableIndexer was initialized with no use. This CL eliminates that by creating it as needed. Golem says: ia32 whole stack (i.e. together with the utf8 stuff) AstToBinary (Intel Xeon) 4.265% (0.3 noise) AstToBinaryP50 (Intel Xeon) 4.364% (0.3 noise) AstToBinaryP90 (Intel Xeon) 4.365% (0.3 noise) AstToBinaryP90 (Intel Core i5) 5.890% (0.3 noise) AstToBinary (Intel Core i5) 5.772% (0.3 noise) AstToBinaryP50 (Intel Core i5) 6.004% (0.4 noise) by itself (i.e. compared to the one with hte utf8 stuff) AstToBinary (Intel Xeon) 0.4910% (0.0 noise) AstToBinaryP50 (Intel Xeon) 0.6186% (0.0 noise) AstToBinaryP90 (Intel Xeon) 0.6415% (0.0 noise) AstToBinaryP90 (Intel Core i5) 1.974% (0.1 noise) AstToBinary (Intel Core i5) 1.854% (0.1 noise) AstToBinaryP50 (Intel Core i5) 2.072% (0.1 noise) whole stack (i.e. together with the utf8 stuff) whole stack AstToBinaryP90 (Intel Core i5) 5.457% (0.2 noise) AstToBinaryP50 (Intel Xeon) 5.150% (0.4 noise) AstToBinary (Intel Xeon) 5.552% (0.4 noise) AstToBinaryP90 (Intel Xeon) 5.756% (0.4 noise) AstToBinaryP50 (Intel Core i5) 4.809% (0.4 noise) AstToBinary (Intel Core i5) 5.099% (0.5 noise) by itself (i.e. compared to the one with hte utf8 stuff) AstToBinaryP50 (Intel Core i5) -0.6758% (-0.1 noise) AstToBinary (Intel Core i5) -0.0593% (-0.0 noise) AstToBinaryP90 (Intel Core i5) 1.292% (0.0 noise) AstToBinaryP50 (Intel Xeon) 0.6355% (0.0 noise) AstToBinaryP90 (Intel Xeon) 0.9089% (0.1 noise) AstToBinary (Intel Xeon) 0.9836% (0.1 noise) Change-Id: Ia9a86958f9a9280c6ee40695fe3020debb8312a5 Reviewed-on: https://dart-review.googlesource.com/c/85340 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Peter von der Ahé <ahe@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.