commit | 5410bc40982138226a96c0b9a01035e121016ea2 | [log] [tgz] |
---|---|---|
author | Jens Johansen <jensj@google.com> | Fri Nov 30 12:57:17 2018 +0000 |
committer | commit-bot@chromium.org <commit-bot@chromium.org> | Fri Nov 30 12:57:17 2018 +0000 |
tree | ea6c946d321ddee4448658b51f035a08e90aeb72 | |
parent | 8db293ed70ecdcc9d1f57e2be7297b3b2fba0232 [diff] |
Fix rare crash in type inference engine Before this CL, running fasta compile on these 3 tests would make it crash in type inference because the enclosingClass on a constrcutor is null: tests/language_2/const_error_multiply_initialized_test.dart tests/language_2/constructor_duplicate_final_test.dart tests/language_2/field3_test.dart Note that these tests are all multi-tests and they are here run unprocessed. The compiler crashes only after issuing errors. The crash likely happens because of multiple definitions of constructors with the same name. This is a cut-down version that crashed prior to this CL: ``` class C { final d; C() {} C(this.d) {} } ``` Fixes #35258. Change-Id: I350c55428932ef0ae76f78875177b08acf95cdfc Reviewed-on: https://dart-review.googlesource.com/c/85363 Reviewed-by: Peter von der Ahé <ahe@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.