commit 52db62dd65284192755906691baf66c47a43f47e
author Johnni Winther <johnniwinther@google.com> Fri Dec 25 23:32:17 2020 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Fri Dec 25 23:32:17 2020 +0000
tree e8e9ddf446d6ef5c4fed79f6a9de37aa37ff444f
parent c7b6e6aa99e76e44d7f807c90ac9f1fc229a9968

[cfe] Use MixinSuperStub

This CL adds stub for each concrete mixed in member into mixin
applications. The body of the stub calls the original member via
a super call.

This addition means that resolution of super access now use the
stub and not the original declaration as the target, which means
that it will be correct even when mixed in members are cloned. For
this reason, dart2js no longer needs to perform its own super
member resolution.

When a super call targets a mixin super stub (after cloning) it
can be optimized away by redirecting the call to the `stubTarget`
of the call. This optimization is performed in dart2js.

Since dart2js now uses the correct super target, its runtime
mixin application needs to avoid overriding members already
declared in the mixin application. These members are the
forwarding super stubs which ensure that correct runtime types
when members with covariant parameters are implemented.


Change-Id: Iab71ffcc400aa6a683987bc20b9553a263ebc8e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176526
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>