tree 1598ef7dfb9880a7f8440e65bf84b65160551767
parent 9672d69a0691ef66a4b554537e26c8c0f95fcbe6
author Mike Fairhurst <mfairhurst@google.com> 1528306704 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1528306704 +0000

Fix a bug in optional const: missing instantiation to bounds on ctors

Part of #30384. This was usually not a problem as most cases involve
additional visitors which rewrite this (for instance, inference).

However, in some cases (appears to be summaries only), that extra
resolution is not needed/skipped, so the non-instantiated constructors
remain.

That makes the constantValue of annotations vulnerable to this, and the
resulting DartObject types will have 'TypeParameterType's for there
typeArguments.

Instantiate the types to bounds, and get the ctor from the type rather
than the element, inside of AstRewriter in order to ensure these
constructors are instantiated.

Change-Id: I65f55feb751e139e68c774786bfbc53788d32995
Reviewed-on: https://dart-review.googlesource.com/58800
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>