| commit | 4d23db795c478d0352704e6d5837e882ee147e04 | [log] [tgz] |
|---|---|---|
| author | Mike Fairhurst <mfairhurst@google.com> | Wed Jun 06 17:38:24 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Wed Jun 06 17:38:24 2018 +0000 |
| tree | 1598ef7dfb9880a7f8440e65bf84b65160551767 | |
| parent | 9672d69a0691ef66a4b554537e26c8c0f95fcbe6 [diff] |
Fix a bug in optional const: missing instantiation to bounds on ctors Part of #30384. This was usually not a problem as most cases involve additional visitors which rewrite this (for instance, inference). However, in some cases (appears to be summaries only), that extra resolution is not needed/skipped, so the non-instantiated constructors remain. That makes the constantValue of annotations vulnerable to this, and the resulting DartObject types will have 'TypeParameterType's for there typeArguments. Instantiate the types to bounds, and get the ctor from the type rather than the element, inside of AstRewriter in order to ensure these constructors are instantiated. Change-Id: I65f55feb751e139e68c774786bfbc53788d32995 Reviewed-on: https://dart-review.googlesource.com/58800 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.