| commit | 4d1b41823061b17dea1418e45688d2f8dc8b2c27 | [log] [tgz] |
|---|---|---|
| author | Danny Tuppeny <danny@tuppeny.com> | Tue Jun 27 14:54:10 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jun 27 14:54:10 2023 +0000 |
| tree | 302d5e83064822211ce45af703cff71bdae69bd9 | |
| parent | f041dd4af4af3e95ea653039315a165034b864e4 [diff] |
[dds/dap] Fix breakpoint resolution races when there are multiple isolates When there are multiple isolates, we may get breakpoint responses/events like this: - Request/Response to add breakpoint to Isolate 1 - Request/Response to add breakpoint to Isolate 2 - BreakpointAdded for Isolate 1 - BreakpointResolved for Isolate 1 - BreakpointAdded for Isolate 2 Because Isolate 2 did not load the script, the last breakpoint was never resolved. However because the breakpoint ID matched, we would forward this event to the client and un-resolve the previously resolved breakpoint. This would result in odd behaviour in VS Code. Additionally, the VM may return the same BM breakpoint ID for what the client thinks are two breakpoints (they are on different lines, but resolve to the same location) so when we get a resolved breakpoint, we need to handle both: - Client breakpoints that have already been transmitted - Future client breakpoints that may resolve to this same VM breakpoint The previous code assumed that a BreakpointResolved event could be handled just once. Either for an existing breakpoint, or a future one. This change swaps from storing queued events to storing the resolution information for each breakpoint, and it does this even if there was an existing breakpoint (in case the breakpoint is reused in future). Fixes at least some of https://github.com/Dart-Code/Dart-Code/issues/4598 Change-Id: I53b92debfaa0c8f538dc8d67966854bb89634708 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311480 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.