)]}'
{
  "commit": "4bcb0950f130805f284cd78f176d32054f14e50b",
  "tree": "9607c4763840f542c4e038ef351d22e0a9331bcc",
  "parents": [
    "d07ab72fb9170e40c6f0ae1eeb22bd0bc08f041a"
  ],
  "author": {
    "name": "Sigmund Cherem",
    "email": "sigmund@google.com",
    "time": "Wed Oct 25 15:37:50 2023 +0000"
  },
  "committer": {
    "name": "Commit Queue",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Oct 25 15:37:50 2023 +0000"
  },
  "message": "[web] fix improperly migrated tests.\n\nThese tests had bugs intronduced during the the null-safety test\nmigration. Surprisingly the failures didn\u0027t show up on some\nconfigurations because the tests were previosly not using the\nasync-helper wrapper. As a result, the test was logged as completed and\npassing before it was done executing. Together this was the cause why\nthese tests failed in d8 and flaked in firefox.\n\nThis CL fixes both issues. A few notes:\n* web_2 tests didn\u0027t have bugs, but this CL also adds asyncHelper to\n  match\n* it\u0027s quite possible that many of these `is` tests are optimized away\n  in dart2js. I added a couple `confuse` calls when the trivial tests\n  were highlighted by the analyzer directly (not based on whether or not\n  dart2js optimized them away).\n\nChange-Id: I8f58c0b0b850023764524f57201eada89a5c0d6d\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/332062\nReviewed-by: Stephen Adams \u003csra@google.com\u003e\nCommit-Queue: Sigmund Cherem \u003csigmund@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "91c907538f4c18004f5806f5af74921e102e65cc",
      "old_mode": 33188,
      "old_path": "tests/web/deferred_function_types1_test.dart",
      "new_id": "842521f2124d58fd9caa158a0bc66f0ff286d5a2",
      "new_mode": 33188,
      "new_path": "tests/web/deferred_function_types1_test.dart"
    },
    {
      "type": "modify",
      "old_id": "4336421b8540a5b5f66c2b87c9f892c4e04b5c33",
      "old_mode": 33188,
      "old_path": "tests/web/deferred_function_types2_test.dart",
      "new_id": "99e81a04934433628a922265380d75ebe1fd61de",
      "new_mode": 33188,
      "new_path": "tests/web/deferred_function_types2_test.dart"
    },
    {
      "type": "modify",
      "old_id": "98a6de8df91a7419a1417c6922c9dd4472c0e9ba",
      "old_mode": 33188,
      "old_path": "tests/web/deferred_function_types3_test.dart",
      "new_id": "ebd2eec49b7bb9e7c7a3e29f1598859552cff684",
      "new_mode": 33188,
      "new_path": "tests/web/deferred_function_types3_test.dart"
    },
    {
      "type": "modify",
      "old_id": "fc78d96a8bd13505f8d8c11a5a6913ba623ea481",
      "old_mode": 33188,
      "old_path": "tests/web/deferred_function_types4_test.dart",
      "new_id": "7577065d49cc24b1a7435521bd27da80ff169900",
      "new_mode": 33188,
      "new_path": "tests/web/deferred_function_types4_test.dart"
    },
    {
      "type": "modify",
      "old_id": "998d678ba49fc59d74b47e44899ad5378500299f",
      "old_mode": 33188,
      "old_path": "tests/web/deferred_function_types5_test.dart",
      "new_id": "da9019690fac3ae9cbc3401284993fac90482f02",
      "new_mode": 33188,
      "new_path": "tests/web/deferred_function_types5_test.dart"
    },
    {
      "type": "modify",
      "old_id": "2423b523276e21b8b9af1e82320731bdaf62a618",
      "old_mode": 33188,
      "old_path": "tests/web/deferred_function_types6_test.dart",
      "new_id": "d0d2b57eeb72628d65f31f7a0212906dd9e179c5",
      "new_mode": 33188,
      "new_path": "tests/web/deferred_function_types6_test.dart"
    },
    {
      "type": "modify",
      "old_id": "fe7c49e1d7e09f45d04ac233445c4bcdeacd31e6",
      "old_mode": 33188,
      "old_path": "tests/web/deferred_function_types7_test.dart",
      "new_id": "6627800eb24a92cdb713752b4a6819a97ea991c7",
      "new_mode": 33188,
      "new_path": "tests/web/deferred_function_types7_test.dart"
    },
    {
      "type": "modify",
      "old_id": "7222ef5c257255de3a5c2023965c3f9db3908016",
      "old_mode": 33188,
      "old_path": "tests/web/deferred_function_types8_test.dart",
      "new_id": "859cd00c3f152c6591f4bd8731c4e1e8f5bf885e",
      "new_mode": 33188,
      "new_path": "tests/web/deferred_function_types8_test.dart"
    },
    {
      "type": "modify",
      "old_id": "8a3a06f60d73107706861217d4ffb8bbe410d446",
      "old_mode": 33188,
      "old_path": "tests/web/deferred_function_types_lib1.dart",
      "new_id": "f94ba3e0a46bf30985e9c0908ff8598e83307ba3",
      "new_mode": 33188,
      "new_path": "tests/web/deferred_function_types_lib1.dart"
    },
    {
      "type": "modify",
      "old_id": "a209dacd93935987de332be45d8d8039c9faf79e",
      "old_mode": 33188,
      "old_path": "tests/web/deferred_function_types_lib2.dart",
      "new_id": "4df39cd53be101ddd6a246a7be8a6b19e4c3b908",
      "new_mode": 33188,
      "new_path": "tests/web/deferred_function_types_lib2.dart"
    },
    {
      "type": "modify",
      "old_id": "2e853e1ca065c71cf1bae174889466f5e8850048",
      "old_mode": 33188,
      "old_path": "tests/web_2/deferred_function_types1_test.dart",
      "new_id": "607c1407e9fe90c85960518e65e5fe68ca75270f",
      "new_mode": 33188,
      "new_path": "tests/web_2/deferred_function_types1_test.dart"
    },
    {
      "type": "modify",
      "old_id": "586e1b8dcf7de49c9f8018ca1c2ebdaaf036acb5",
      "old_mode": 33188,
      "old_path": "tests/web_2/deferred_function_types2_test.dart",
      "new_id": "087996efa318dc8a208e481419167ce45f75a164",
      "new_mode": 33188,
      "new_path": "tests/web_2/deferred_function_types2_test.dart"
    },
    {
      "type": "modify",
      "old_id": "10d69f47d8aa3a20682804983d31327dc0dd1824",
      "old_mode": 33188,
      "old_path": "tests/web_2/deferred_function_types3_test.dart",
      "new_id": "06968223f26c05303328a65ac2b023aff19cd4a9",
      "new_mode": 33188,
      "new_path": "tests/web_2/deferred_function_types3_test.dart"
    },
    {
      "type": "modify",
      "old_id": "27fedbc933039373000643eccb69e69fb0aa050e",
      "old_mode": 33188,
      "old_path": "tests/web_2/deferred_function_types4_test.dart",
      "new_id": "3277948001c2c46b14a9ea52871d3ea381007dbe",
      "new_mode": 33188,
      "new_path": "tests/web_2/deferred_function_types4_test.dart"
    },
    {
      "type": "modify",
      "old_id": "75b04e3285efbfcbb50359c8ccd2ccd5207dcb93",
      "old_mode": 33188,
      "old_path": "tests/web_2/deferred_function_types5_test.dart",
      "new_id": "33fb076bcd89b05ffcb9bae1a9055868ff56ca30",
      "new_mode": 33188,
      "new_path": "tests/web_2/deferred_function_types5_test.dart"
    },
    {
      "type": "modify",
      "old_id": "0a1b2a7921c61db6b6c8d83bb2d9230645663015",
      "old_mode": 33188,
      "old_path": "tests/web_2/deferred_function_types6_test.dart",
      "new_id": "14105a984d8300ab51740237373526443ea1cea8",
      "new_mode": 33188,
      "new_path": "tests/web_2/deferred_function_types6_test.dart"
    },
    {
      "type": "modify",
      "old_id": "ba16f2eecd90e3ef659a33910c4edcc761dc05e5",
      "old_mode": 33188,
      "old_path": "tests/web_2/deferred_function_types7_test.dart",
      "new_id": "38163a589bdcf5317e892fc5a86833a9e202b552",
      "new_mode": 33188,
      "new_path": "tests/web_2/deferred_function_types7_test.dart"
    },
    {
      "type": "modify",
      "old_id": "f6624a1dfbd0b1708ef4e800f9f95bfdc3089b1a",
      "old_mode": 33188,
      "old_path": "tests/web_2/deferred_function_types8_test.dart",
      "new_id": "35abeb84f33e1571c5bb43551afee44cf8065b1c",
      "new_mode": 33188,
      "new_path": "tests/web_2/deferred_function_types8_test.dart"
    }
  ]
}