Create a base class for non-error resolver test cases.
This avoids the need to override tests in NonErrorResolverTest_Driver
to indicate that they pass.
Change-Id: I2a980889bc3e32db2c6ac3873bf439a12b23c63e
Reviewed-on: https://dart-review.googlesource.com/75660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
diff --git a/pkg/analyzer/test/generated/non_error_resolver_driver_test.dart b/pkg/analyzer/test/generated/non_error_resolver_driver_test.dart
index 8076e7e..c524c9c 100644
--- a/pkg/analyzer/test/generated/non_error_resolver_driver_test.dart
+++ b/pkg/analyzer/test/generated/non_error_resolver_driver_test.dart
@@ -13,29 +13,31 @@
}
@reflectiveTest
-class NonErrorResolverTest_Driver extends NonErrorResolverTest {
+class NonErrorResolverTest_Driver extends NonErrorResolverTestBase {
@override
bool get enableNewAnalysisDriver => true;
- @override // Passes with driver
- test_infer_mixin() => super.test_infer_mixin();
+ @override
+ @failingTest
+ test_constConstructorWithMixinWithField_withoutSuperMixins() {
+ return super.test_constConstructorWithMixinWithField_withoutSuperMixins();
+ }
- @override // Passes with driver
- test_infer_mixin_multiplyConstrained() =>
- super.test_infer_mixin_multiplyConstrained();
+ @override
+ @failingTest
+ test_intLiteralInDoubleContext_const_exact() {
+ return super.test_intLiteralInDoubleContext_const_exact();
+ }
- @override // Passes with driver
- test_infer_mixin_with_substitution() =>
- super.test_infer_mixin_with_substitution();
+ @override
+ @failingTest
+ test_null_callMethod() {
+ return super.test_null_callMethod();
+ }
- @override // Passes with driver
- test_infer_mixin_with_substitution_functionType() =>
- super.test_infer_mixin_with_substitution_functionType();
-
- @override // Passes with driver
- test_issue_32394() => super.test_issue_32394();
-
- @override // Passes with driver
- test_mixinInference_with_actual_mixins() =>
- super.test_mixinInference_with_actual_mixins();
+ @override
+ @failingTest
+ test_null_callOperator() {
+ return super.test_null_callOperator();
+ }
}
diff --git a/pkg/analyzer/test/generated/non_error_resolver_test.dart b/pkg/analyzer/test/generated/non_error_resolver_test.dart
index b5a00ae..3f637e7 100644
--- a/pkg/analyzer/test/generated/non_error_resolver_test.dart
+++ b/pkg/analyzer/test/generated/non_error_resolver_test.dart
@@ -25,7 +25,69 @@
}
@reflectiveTest
-class NonErrorResolverTest extends ResolverTestCase {
+class NonErrorResolverTest extends NonErrorResolverTestBase {
+ @override
+ @failingTest
+ test_constConstructorWithMixinWithField_withoutSuperMixins() {
+ return super.test_constConstructorWithMixinWithField_withoutSuperMixins();
+ }
+
+ @override
+ @failingTest // Does not work with old task model
+ test_infer_mixin() {
+ return super.test_infer_mixin();
+ }
+
+ @override
+ @failingTest // Does not work with old task model
+ test_infer_mixin_multiplyConstrained() {
+ return super.test_infer_mixin_multiplyConstrained();
+ }
+
+ @override
+ @failingTest // Does not work with old task model
+ test_infer_mixin_with_substitution() {
+ return super.test_infer_mixin_with_substitution();
+ }
+
+ @override
+ @failingTest // Does not work with old task model
+ test_infer_mixin_with_substitution_functionType() {
+ return super.test_infer_mixin_with_substitution_functionType();
+ }
+
+ @override
+ @failingTest
+ test_intLiteralInDoubleContext_const_exact() {
+ return super.test_intLiteralInDoubleContext_const_exact();
+ }
+
+ @override
+ @failingTest // Fails with the old task model
+ test_issue_32394() {
+ return super.test_issue_32394();
+ }
+
+ @override
+ @failingTest // Does not work with old task model
+ test_mixinInference_with_actual_mixins() {
+ return super.test_mixinInference_with_actual_mixins();
+ }
+
+ @override
+ @failingTest
+ test_null_callMethod() {
+ return super.test_null_callMethod();
+ }
+
+ @override
+ @failingTest
+ test_null_callOperator() {
+ return super.test_null_callOperator();
+ }
+}
+
+class NonErrorResolverTestBase extends ResolverTestCase {
@override
AnalysisOptions get defaultAnalysisOptions => new AnalysisOptionsImpl();
@@ -1215,7 +1277,6 @@
verify([source]);
}
- @failingTest
test_constConstructorWithMixinWithField_withoutSuperMixins() async {
Source source = addSource(r'''
class M {
@@ -2575,7 +2636,6 @@
verify([source]);
}
- @failingTest // Does not work with old task model
test_infer_mixin() async {
AnalysisOptionsImpl options = new AnalysisOptionsImpl();
options.enableSuperMixins = true;
@@ -2599,7 +2659,6 @@
expect(classC.mixins[0].toString(), 'M<B>');
}
- @failingTest // Does not work with old task model
test_infer_mixin_multiplyConstrained() async {
AnalysisOptionsImpl options = new AnalysisOptionsImpl();
options.enableSuperMixins = true;
@@ -2629,7 +2688,6 @@
expect(classF.mixins[0].toString(), 'M<C, D>');
}
- @failingTest // Does not work with old task model
test_infer_mixin_with_substitution() async {
AnalysisOptionsImpl options = new AnalysisOptionsImpl();
options.enableSuperMixins = true;
@@ -2653,7 +2711,6 @@
expect(classC.mixins[0].toString(), 'M<B>');
}
- @failingTest // Does not work with old task model
test_infer_mixin_with_substitution_functionType() async {
AnalysisOptionsImpl options = new AnalysisOptionsImpl();
options.enableSuperMixins = true;
@@ -2845,7 +2902,6 @@
verify([source]);
}
- @failingTest
test_intLiteralInDoubleContext_const_exact() async {
// TODO(mfairhurst): get the commented out assertions to pass.
Source source = addSource(r'''
@@ -3555,7 +3611,6 @@
verify([source]);
}
- @failingTest // Fails with the old task model
test_issue_32394() async {
Source source = addSource('''
var x = y.map((a) => a.toString());
@@ -3820,7 +3875,6 @@
verify([source]);
}
- @failingTest // Does not work with old task model
test_mixinInference_with_actual_mixins() async {
Source source = addSource('''
class I<X> {}
@@ -4732,7 +4786,6 @@
verify([source]);
}
- @failingTest
test_null_callMethod() async {
Source source = addSource(r'''
main() {
@@ -4742,7 +4795,6 @@
assertErrors(source, [StaticTypeWarningCode.UNDEFINED_METHOD]);
}
- @failingTest
test_null_callOperator() async {
Source source = addSource(r'''
main() {
