| commit | 4a95930f0dccb4890c2bfbd5c5410fd93d844fe1 | [log] [tgz] |
|---|---|---|
| author | Srujan Gaddam <srujzs@google.com> | Fri Dec 01 22:28:05 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Dec 01 22:28:05 2023 +0000 |
| tree | 7ff1e00f3f9354c0493c7097239f8f2690709be0 | |
| parent | 363f07e89a3469af0178bfb9397ee574b0e531f1 [diff] |
[dart2js] Fix registering of allowInterop impact This impact was added so the compiler would correctly consider JavaScriptFunction live when allowInterop was used. At some point, this behavior regressed but the effect of this was hidden by the existence of dart:js_interop JS types. Because the JS types were implemented using package:js classes, the compiler assumed JavaScriptFunction was always live. As we are migrating them to extension types, this bug resurfaced. There are two key details in this CL: - The allowInterop impact needs to register that JavaScriptFunction is instantiated. needToInitializeIsolateAffinityTag is not enough. - Both resolution and codegen need to add the impact. Before this CL, we checked for use of allowInterop during SSA and registered that it was being used, and we only processed the impact if it was being used. However, this check of the registration only occurred during resolution. Since resolution occurs before codegen, we never actually processed the impact. It isn't clear why both details are needed for tests/web/regress/issue/37576_test to pass. Change-Id: Ieff8ac5c4d040cc034f58ecb09a4246d2d8f87b7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336626 Reviewed-by: Stephen Adams <sra@google.com> Commit-Queue: Srujan Gaddam <srujzs@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.