)]}' { "commit": "49b18446c2fd505509112083edade7a5d5911984", "tree": "9c6bd86716eec29e469bc1ee05b5de91321365e1", "parents": [ "bc8a8386af7f5abfec856ef4f2fcc870a51f9b96" ], "author": { "name": "danrubel", "email": "danrubel@google.com", "time": "Tue Aug 07 16:07:09 2018 +0000" }, "committer": { "name": "commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Aug 07 16:07:09 2018 +0000" }, "message": "Refactor dartdoc parsing\n\nThis extracts and refactors a sizable chunk of dartdoc parsing out of AstBuilder\nand into the fasta parser. Parsing dartdoc does not happen unless the listener\ncalls the new fasta parser parseCommentReferences method.\n\nThe new parseCommentReferences method generates a handleCommentReferenceText\nevent for each comment reference encountered. The listener calls the scanner\nto tokenize the comment reference and forwards the result to a new\nfasta parser parseOneCommentReference method. This method generates either\na handleCommentReference or a handleNoCommentReference depending upon\nwhether or not a reference is parsed.\n\nparser.parseCommentReferences\n* generates handleCommentReferenceText events\n* returns # of events generated\n\nlistener.handleCommentReferenceText\n* calls parser.parseOneCommentReference\n\nparser.parseOneCommentReference\n* generates either handleCommentReference or handleNoCommentReference\n\nThere are further improvements to be made, but I believe this chunk\nwill allow progress to be made on the kernel side.\n\nChange-Id: I393dc4d1d4791b3d7a529f6cb3c16db3a5befddf\nReviewed-on: https://dart-review.googlesource.com/68461\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "55dda565dbc9bd25eeae4de0c732490d4f13df52", "old_mode": 33188, "old_path": "pkg/analyzer/lib/src/fasta/ast_builder.dart", "new_id": "969e984cbeba1bfe96002fc8937fa790e4644362", "new_mode": 33188, "new_path": "pkg/analyzer/lib/src/fasta/ast_builder.dart" }, { "type": "modify", "old_id": "3b7f3412e53cd36d8654dbe0d3fdc8ec9fd2c305", "old_mode": 33188, "old_path": "pkg/analyzer/test/generated/parser_fasta_test.dart", "new_id": "df2e4c7b2935a7576d433d0bfab300a83b12c17f", "new_mode": 33188, "new_path": "pkg/analyzer/test/generated/parser_fasta_test.dart" }, { "type": "modify", "old_id": "cd6334f35ad3f5a78b08959ef661aad6394c478f", "old_mode": 33188, "old_path": "pkg/analyzer/test/generated/parser_test.dart", "new_id": "f06a44bfa22cb8c8671cb820b0d71eb24b5ab15b", "new_mode": 33188, "new_path": "pkg/analyzer/test/generated/parser_test.dart" }, { "type": "modify", "old_id": "467e833d65605139468d4b60c8023b8a6d18a078", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/parser/forwarding_listener.dart", "new_id": "a471f62cb71ff4f779cc98260005b1ce2f9360fb", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/parser/forwarding_listener.dart" }, { "type": "modify", "old_id": "1f6dd5cac23e830098eee4ec9a6eadc1e8dbb1da", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/parser/listener.dart", "new_id": "8c45723b9d4d48feb7c667b9b8a8b722ddff260a", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/parser/listener.dart" }, { "type": "modify", "old_id": "daf4bbf4319295babdbf57f42303955d819bba6d", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/parser/parser.dart", "new_id": "c3071fd45737302d9273b2561d8b1c2fd96e2d0f", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/parser/parser.dart" }, { "type": "modify", "old_id": "ab00611c1321fca915ffa5d7973400cfae608e4a", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/parser/util.dart", "new_id": "4329810d4bd9a8efc2b91cee37f914fc8c063ebc", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/parser/util.dart" }, { "type": "modify", "old_id": "df55a69b9884d6089f6094e68570fde200ef170f", "old_mode": 33188, "old_path": "pkg/front_end/lib/src/fasta/source/stack_listener.dart", "new_id": "e7f2eb4a3d7c037f1f4ec1132c2521ad7f9b35a7", "new_mode": 33188, "new_path": "pkg/front_end/lib/src/fasta/source/stack_listener.dart" } ] }