tree 0783e3558571285b44d5edfe7bbfb7482e4a705f
parent cc2fac57f31442fc9a66960d51bc049d80a6e177
author Alexander Markov <alexmarkov@google.com> 1558654822 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1558654822 +0000

[vm] Do expensive kernel metadata verification only once per kernel

In DEBUG mode during AOT compilation MetadataHelper::SetMetadataMappings
may spend considerable time verifying that node offsets are sorted
in kernel metadata. The problem is that there are a lot of MetadataHelpers
created (several per each compiled function).

This change moves verification of kernel metadata mappings to
the kernel loader, so it is performed only once per kernel program.

AOT gen_snapshot time on a small test:
Before: 11.680s
After: 9.041s

Change-Id: I1c0a676b0ed28fc5cfa756ca60159f914190fac0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103486
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>