tree 1fa34412b631722a33a1367456c8d7ae2eaa34ae
parent bd1ffcb2bd471f7782f49622d968764f9d6f12ee
author Konstantin Shcheglov <scheglov@google.com> 1561132397 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1561132397 +0000

Report MISSING_DEFAULT_VALUE_FOR_PARAMETER only when NNBD is enabled.

It works now, because we consider types in opt-out libraries as S*,
and so far TypsSystem.isPotentiallyNonNullable(S*) returns false,
because TypeSystem.isNullable(S*) returns true. But I think this
is wrong. The spec says:

We say that a type T is nullable if Null <: T. This is equivalent to
the syntactic criterion that T is any of:
<cut>
- S* for some S where S is nullable
<cut>

  So, we currently say that `int*` is nullable.
  But this is wrong - `int` is not nullable.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I87340fbed23cebd3d68c92579b7d1785b2fc097a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106952
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>