commit 447736882339995cf1f3a4f015901d4ca8a393ef
author Siva Annamalai <asiva@google.com> Tue Jul 09 22:35:19 2024 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jul 09 22:35:19 2024 +0000
tree b7e83a3b864c420798fc25c93ad5fdee48f05718
parent 3d3bbe9c00d69937990de8d694b209f715b4918c

Revert "[dart2wasm] Do not assign class ids to anonymous mixin classes."

This reverts commit dc2d5b539eb4f99f66a4257378e1ad6c81085956.

Reason for revert: see https://github.com/flutter/flutter/issues/151473

Original change's description:
> [dart2wasm] Do not assign class ids to anonymous mixin classes.
>
> Anonymous mixin application classes get created as a desguaring of mixin
> applications.
>
> For example this
>
>    mixin M {
>      <M-body>
>    }
>    class Base {}
>    class A extends Base with M {}
>
> gets desugared into
>
>    class Base {}
>    abstract class A&Base&M1 extends Base implements M /*isAnonymousMixin*/ {
>      <copy-of-M-body>
>    }
>    class A extends A&Base&M1 {}
>
> Those anonymous mixin application classes are not real classes: They cannot
> be named in code, cannot be used as type arguments, type literals, type
> checks etc,
>
> => This CL avoids assigning class ids to them.
> => This will shrink the type name array.
> => This will shrink RTT information.
> => This makes other classes get lower ids assigned
>
> Size changes of `...opt.wasm` file:
> * Hello: -5%
> * FluteComplex: -1.5%
>
> Change-Id: Ic5b583058bb556b19431fdcb47c5a20d2f6ad244
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374320
> Reviewed-by: Ömer Ağacan <omersa@google.com>
> Commit-Queue: Martin Kustermann <kustermann@google.com>

Change-Id: I5df991e8124afecd8518a799b1b68ea0cb4b85fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375041
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>