| commit | 433bc1b35070051cdf498a500ef726ef08fbdb4b | [log] [tgz] |
|---|---|---|
| author | Alexander Markov <alexmarkov@google.com> | Mon May 20 17:38:14 2019 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Mon May 20 17:38:14 2019 +0000 |
| tree | 65373da50fef156fbe231301281b84f09ef15a1e | |
| parent | 04e329b6ede7954a40d8121347a55bb385a1139a [diff] |
[vm/compiler] Avoid adding unused Redefinition instructions Type propagator adds Redefinition instructions to provide more accurate type information only for dominated uses (for example, to mark receiver as non-nullable after instance calls). However, adding Redefinition instructions may interfere with branch simplification, which looks only at empty join blocks. This change avoids adding unused Redefinition instructions (if there are no dominated uses). This particular situation happens in Flutter in RenderObject.layout() where constraints.isTight is inlined with multiple polymorphic targets, including SliverConstraints.isTight which returns false. Branch simplification was not happening due to Redefinition instruction for 'constraints'. That Redefinition instruction is not used. Change-Id: I15082bacd7cc6ea1445a4dadc8ef97853142ba74 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103023 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.