)]}' { "commit": "4317c5ff3fd637e3bdc3afc248e47f4cfb2aa10d", "tree": "6f858a9e7f0ccc446610a431ad7cdba1853df623", "parents": [ "6457ac1d4b73367dffceaaaa4c01be4c6f2ad0b8" ], "author": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Wed May 22 03:29:17 2019 +0000" }, "committer": { "name": "Konstantin Shcheglov", "email": "scheglov@google.com", "time": "Wed May 22 03:29:17 2019 +0000" }, "message": "Don\u0027t set elements and types during AstRewriteVisitor.\n\nResolution is incomplete at the time when we perform rewriting.\nFor example, in `C\u003cint\u003e` the type of `int` is not set, so we get\nincomplete InterfaceType of `C` with `null` as the type argument.\nThis was crashing summary2 in one situation internally.\n\nR\u003dbrianwilkerson@google.com\n\nChange-Id: Ifcff68f007a90b5694cf3e4e4d3825309c04e2b8\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/103382\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "f66ceb780002db3d07442d3e61c34d8fd3a04434", "old_mode": 33188, "old_path": "pkg/analyzer/lib/src/generated/resolver.dart", "new_id": "0382710c60c95fb8d477a0a61d95a4850d58908f", "new_mode": 33188, "new_path": "pkg/analyzer/lib/src/generated/resolver.dart" }, { "type": "modify", "old_id": "73fc758d5cdaadf8e1cdb49c514a457de4017f3c", "old_mode": 33188, "old_path": "pkg/analyzer/test/src/dart/analysis/driver_resolution_test.dart", "new_id": "49d54a84247c4cb60115780d60c857137293c4d1", "new_mode": 33188, "new_path": "pkg/analyzer/test/src/dart/analysis/driver_resolution_test.dart" }, { "type": "modify", "old_id": "813eec570d0ef353d903ec3064bc825615dd6642", "old_mode": 33188, "old_path": "pkg/analyzer/test/src/dart/resolution/optional_const_test.dart", "new_id": "5a47b69e2be78eb75b8239fed6d11149ad0dd7c6", "new_mode": 33188, "new_path": "pkg/analyzer/test/src/dart/resolution/optional_const_test.dart" } ] }