tree 07c376c9bf7f2efb460af9a175afff26223c04f9
parent e8659b0f288c4a76499eaca6742f08bcb5c1a4b8
author Samir Jindel <sjindel@google.com> 1527791806 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1527791806 +0000

[vm] Fix non-reproducibility of VM builds.

We recently removed two kind bits from `Function` to free up space for other
bits. This left two bits in `RawFunction::kind_tag_` unused and no longer
deterministically initialized. This caused `Function` objects saved in the
snapshot within the `.rodata` section of the `dart` binary to be serialized with
a non-deterministic kind tag. We now zero-initialize the kind tag.

# Test Plan

I built the `runtime` target (which includes `dart`) 10 times locally and
received the same SHA256 hash for `dart` each time.

Change-Id: Ib0de4b4b040e26a92a1ba3364460bcec0f665789
Reviewed-on: https://dart-review.googlesource.com/57624
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>