)]}'
{
  "commit": "403040c2f7cd245a69cb249e20f4e531f70d565e",
  "tree": "af643c9d1f07b523fa136d0d00fca82ac79525f7",
  "parents": [
    "b771c6f45dc4563b29c26a18ce08034bf1a25b69"
  ],
  "author": {
    "name": "Danny Tuppeny",
    "email": "danny@tuppeny.com",
    "time": "Mon Mar 25 20:55:06 2024 +0000"
  },
  "committer": {
    "name": "Commit Queue",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Mar 25 20:55:06 2024 +0000"
  },
  "message": "[analysis_server] Fix many LSP tests that produce diagnostics\n\nI\u0027m working towards having LSP tests fail by default if error diagnostics are produced. This updates a bunch of tests that currently do, but are not required to.\n\nIn many cases these are minor bugs in the test code and non-null variables without values. Some are where we create multiple files after the server is started (which is not atomic) which are generally updated to just create the files before starting up the server instead (as long as the test was not specifically testing open files).\n\nChange-Id: Ia3adfd413d22b2d3d04d6aba9453b919e0aa46dc\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/359224\nCommit-Queue: Oleh Prypin \u003coprypin@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "07180374c43dfcba6a62d75833d95b04cf634f9a",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/analyzer_status_test.dart",
      "new_id": "ab6d1a56cfddb9fd04854bb7d67b81105e7d5375",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/analyzer_status_test.dart"
    },
    {
      "type": "modify",
      "old_id": "708bf8f058d17d6e89cd48e28fd6a039e2c1af84",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/augmentation_test.dart",
      "new_id": "b99ce08bcb35847d0c7316252d7cd31c38fcc85d",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/augmentation_test.dart"
    },
    {
      "type": "modify",
      "old_id": "6a42a7eb86cc8402c86d8d8073fd67aefdfb5328",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/augmented_test.dart",
      "new_id": "e46279ca81c3fc347bc1d2f4cd1095b92f782996",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/augmented_test.dart"
    },
    {
      "type": "modify",
      "old_id": "e2eb2c6778ddce6f745623a9f00286baaa132d9f",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/call_hierarchy_test.dart",
      "new_id": "7fc5991fec25307843a69b7726da3870a624be09",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/call_hierarchy_test.dart"
    },
    {
      "type": "modify",
      "old_id": "2d0be727c6bc09e7daa44c3aa5dd56c298519aa3",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/cancel_request_test.dart",
      "new_id": "b637a9b1e855a6edf46336644077395b36c7338c",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/cancel_request_test.dart"
    },
    {
      "type": "modify",
      "old_id": "cedfd2f81afb136ac37fc2456a71c1136d121cea",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/code_actions_assists_test.dart",
      "new_id": "78bff1357430596dad980f0ea9ac95054d19ea2d",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/code_actions_assists_test.dart"
    },
    {
      "type": "modify",
      "old_id": "d8d885f58e1a8cd6d99a5c829f75bd8de0a0d24b",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/definition_test.dart",
      "new_id": "b6626321e269440c74039f8150a821ad8c6221ff",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/definition_test.dart"
    },
    {
      "type": "modify",
      "old_id": "b31af10fcf06f37a0f5d93ae036d80a04c930e82",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/folding_test.dart",
      "new_id": "efff7a85614c9d015b5f8992df2de6d4b393ccde",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/folding_test.dart"
    },
    {
      "type": "modify",
      "old_id": "50c013abacaf2920bbce8b7fc9c23479611378bd",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/hover_test.dart",
      "new_id": "4adb65a564e087a63f0bd371e4ec2182aea235de",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/hover_test.dart"
    },
    {
      "type": "modify",
      "old_id": "a3c8571a32683a651de9c94b18b674b724eaa06c",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/implementation_test.dart",
      "new_id": "d644b14b9c34c218df171c764a76673e52315209",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/implementation_test.dart"
    },
    {
      "type": "modify",
      "old_id": "712dbd05fc9ca38857ca761ed2a9177bd00e5547",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/rename_test.dart",
      "new_id": "abfa458f8e17df1ef7e680cea08805842d421576",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/rename_test.dart"
    },
    {
      "type": "modify",
      "old_id": "826e120cb0d3bd91f13267c5f98fab82f2fc10bf",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/semantic_tokens_test.dart",
      "new_id": "a9ba5ce8138772c33effb5cdf9792f4d6189dcdf",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/semantic_tokens_test.dart"
    },
    {
      "type": "modify",
      "old_id": "a1db09daa41c4fb41fa71d0817febf9aa2c66336",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/type_definition_test.dart",
      "new_id": "71114567ae494c0aa7fd1214caff302c9db2afe1",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/type_definition_test.dart"
    },
    {
      "type": "modify",
      "old_id": "07b2a592f2d220c67af0390cb68df66dba6b7159",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/will_rename_files_test.dart",
      "new_id": "adbe260158bde06cb7338b0e38e82c9595cd2790",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/will_rename_files_test.dart"
    }
  ]
}