| commit | 3feab3655c93b8cda3ea09e173fa2a21eec35f39 | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Tue Jan 16 12:13:41 2024 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 16 12:13:41 2024 +0000 |
| tree | 7dd5eed79b4a0bc7b1b2aff81148bac545ffe323 | |
| parent | c5cc9aeb6a566366488e0cb6e02a634d97cb786d [diff] |
[vm/compiler] Fix ARM7 regression after 1827fcbf68bf. The refactoring in https://dart-review.googlesource.com/c/sdk/+/345002 erroneously assumed that if the caller to Assembler::AddressCanHoldConstantIndex didn't pass an out parameter to detect whether a base register was needed, that that case shouldn't be considered. While it's true that LoadIndexedInstr::MakeLocationSummary originally ignored the value stored in the out parameter, it did that because it can use TMP to store the array base, unlike the code for StoreIndexedInstr which must have a temporary register allocated during register allocation. Thus, fix Assembler::AddressCanHoldConstantIndex to always require the out parameter, and add a comment in LoadIndexedInstr as to why we ignore the out parameter in this case instead of allocating an additional temporary register. TEST=vm/cc/Assembler_Regress54621 Fixes: https://github.com/dart-lang/sdk/issues/54621 Change-Id: I0af557565faf657a87641457884334446e9b7cc5 Cq-Include-Trybots: luci.dart.try:vm-ffi-qemu-linux-release-arm-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/346201 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.