tree 1880d82d4cca2d9c5bf4bd54368473bee577a83f
parent bb42e9dad348315e75a93f0614915f0d0cdb3c5a
author Kenzie Schmoll <kenzieschmoll@google.com> 1561490092 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1561490092 +0000

Fixes for service.md.

- getInstances needs a param for isolateId. Without this param, we see runtime errors.
- InstanceSet needs instances to have type @Object[]. We see types of objects here other than
  InstanceRefs (ObjRef, FieldRef, etc.), and we need to be able to handle all types. If we do
  not, we see runtime errors.
- getVMTimeline params should be optional. Before this method was made public, you did not
  have to specify origin / extent times to pull the timeline.

Fixes https://github.com/dart-lang/sdk/issues/37349.
Fixes https://github.com/dart-lang/sdk/issues/37351.


Change-Id: Icb9874cfb102268cc561978a74c11cac02bcfc0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107190
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Schmoll <kenzieschmoll@google.com>