)]}' { "commit": "3e732e5bbe85270cd9864e3600aa68f5f09efda6", "tree": "1880d82d4cca2d9c5bf4bd54368473bee577a83f", "parents": [ "bb42e9dad348315e75a93f0614915f0d0cdb3c5a" ], "author": { "name": "Kenzie Schmoll", "email": "kenzieschmoll@google.com", "time": "Tue Jun 25 19:14:52 2019 +0000" }, "committer": { "name": "commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Jun 25 19:14:52 2019 +0000" }, "message": "Fixes for service.md.\n\n- getInstances needs a param for isolateId. Without this param, we see runtime errors.\n- InstanceSet needs instances to have type @Object[]. We see types of objects here other than\n InstanceRefs (ObjRef, FieldRef, etc.), and we need to be able to handle all types. If we do\n not, we see runtime errors.\n- getVMTimeline params should be optional. Before this method was made public, you did not\n have to specify origin / extent times to pull the timeline.\n\nFixes https://github.com/dart-lang/sdk/issues/37349.\nFixes https://github.com/dart-lang/sdk/issues/37351.\n\n\nChange-Id: Icb9874cfb102268cc561978a74c11cac02bcfc0c\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/107190\nReviewed-by: Ben Konyi \u003cbkonyi@google.com\u003e\nCommit-Queue: Kenzie Schmoll \u003ckenzieschmoll@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "56f3bd73cbc9dd88ebad8be5a6e7ce3b82f79649", "old_mode": 33188, "old_path": "runtime/vm/service/service.md", "new_id": "89e580bdad1ed10a422fa9874da2bda530cc1620", "new_mode": 33188, "new_path": "runtime/vm/service/service.md" }, { "type": "modify", "old_id": "4985682fb5137391430479d577541e0463514339", "old_mode": 33188, "old_path": "runtime/vm/service/service_dev.md", "new_id": "ccf44c170163156ce4c8a546a5527a9e792aca90", "new_mode": 33188, "new_path": "runtime/vm/service/service_dev.md" } ] }