tree c90b851a54e46507146b0d7942956bc165728e94
parent d267fb6bf3502bb1ed69ac7f01d9610a4936f2b1
author Martin Kustermann <kustermann@google.com> 1552685055 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1552685055 +0000

[VM] Define layout of _*ArrayView/_ByteDataView in C+++

This removes the 3 fields from the classes in Dart and instead describes
the layout in C++ via a RawTypedDataView class (as already do with
normal RawTypedData). The existing "semi" TypedDataView handle class is
changed to be a real handle class.

This decreases performance of some microbenchmarks due to field guards
not being used anymore (before the JIT could add a field guard to view classes
guarding that only normal typed data is used as backing store (and not e.g. external
typed data)

Issue https://github.com/dart-lang/sdk/issues/35154
Issue https://github.com/dart-lang/sdk/issues/31954

Change-Id: I7a0022b843a4c0fa69f53dedcc4c7bd2117cdc37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96806
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>