commit 3d95c84db5460009b07d42f32538252eb0ad6ee7
author Konstantin Shcheglov <scheglov@google.com> Wed Aug 20 16:44:13 2025 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 20 16:44:13 2025 -0700
tree ed47f3ad1a604869ad8400d041c8e8450b8b7221
parent c40f1f7dfe8ad0f6fef098ce5c43c2d8e152ccd7

Fine. Add internal analyzer_element_model_tracking lint.

Introduce the internal `analyzer_element_model_tracking` lint to enforce
explicit tracking annotations on analyzer element-model members. This
codifies how each member contributes to IDs, dependency tracking, and
incremental analysis.

Rule behavior (applies to classes annotated with `@elementClass`):
- Public instance **fields** must be annotated with
  `@trackedIncludedInId`.
- Public instance **getters/methods** (non-abstract, non-void) must have
  exactly one of:
  `@trackedDirectly`, `@trackedDirectlyExpensive`,
  `@trackedDirectlyOpaque`, `@trackedIncludedInId`, or
  `@trackedIndirectly`.
- Flags invalid annotations on ineligible members (constructors, setters,
  static or private members).
- Reports when more than one tracking annotation is present.
- Reports when a required annotation is missing.

Wire-up:
- Add lint codes and names:
  - `analyzer_element_model_tracking_bad`
  - `analyzer_element_model_tracking_more_than_one`
  - `analyzer_element_model_tracking_zero`
- Mark these as `noFix` in error-fix status and enable the rule in
  `analysis_options.yaml`.
- Register the rule in the linter.

Model updates:
- Annotate many members in `element.dart` to reflect their tracking
  category (e.g. `@trackedIncludedInId` for identity-affecting members;
  `@trackedDirectlyExpensive` for lazily computed collections).
- For opaque surfaces where precise tracking is impractical (e.g.
  `documentationComment`, `nonSynthetic`, `session`, member lookups,
  ancestor queries, `visitChildren`), record usage via
  `globalResultRequirements?.recordOpaqueApiUse(...)`.

Why:
- Makes dependency/ID semantics explicit and reviewable.
- Improves correctness of incremental and cache invalidation behavior.
- Establishes a foundation for refining precision over time without
  regressions.

Scope:
- Internal only; no public API changes.

Change-Id: Id2beaf5ead35b8a361bc1b7688ccb5b5a74afe88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/446140
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>