)]}'
{
  "commit": "3c161d3fd17c19ad2b6d2f272331e31e608cfd41",
  "tree": "18c8d774e12e76fead697d8d82c59cc9e6ea086e",
  "parents": [
    "b32e5e5a910e7c63d5ac7c6abe7b4de6f3781174"
  ],
  "author": {
    "name": "Danny Tuppeny",
    "email": "danny@tuppeny.com",
    "time": "Tue May 06 11:03:33 2025 -0700"
  },
  "committer": {
    "name": "Commit Queue",
    "email": "dart-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue May 06 11:03:33 2025 -0700"
  },
  "message": "[analysis_server] Move CodeActionKind filter earlier in production of code actions\n\nThis removes a filter of CodeActionKinds from the final step (and a class named `_CodeActionSorter`!) and instead applies it earlier during building of the actions. This will help apply the filter in the case where we return bare Commands (which don\u0027t have `kind`s) instead of `CodeActionLiteral`s.\n\nI added some TODOs because I still don\u0027t think this is filtering early enough (because in the case of invoking an action via the command, we need to not have to produce _all_ code actions just to locate the _one_ we want to execute), but it\u0027s a step closer (and easier to review this without it being lumped in with the CL that supports returning Commands).\n\nChange-Id: Ibc73c4900d939ac833f6345e9e8f1fdf3f5d6823\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/427000\nReviewed-by: Samuel Rawlins \u003csrawlins@google.com\u003e\nReviewed-by: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\nCommit-Queue: Brian Wilkerson \u003cbrianwilkerson@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9d89a7426967151061b010b3978abeab9f00a0e3",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/lsp/handlers/code_actions/abstract_code_actions_producer.dart",
      "new_id": "cc7c851445b99c9cefa601fd50a9259872251a6c",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/lsp/handlers/code_actions/abstract_code_actions_producer.dart"
    },
    {
      "type": "modify",
      "old_id": "f8558d4e925319b9c9283fc1ef726aa7bddb8ee4",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/lsp/handlers/code_actions/analysis_options.dart",
      "new_id": "90d74e50cbfbedbc38f1256d20e1fb45f2b6d671",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/lsp/handlers/code_actions/analysis_options.dart"
    },
    {
      "type": "modify",
      "old_id": "73284c891d67dedbd347a456df728d1dcb1581bd",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart",
      "new_id": "5848c3effd0d86df8e83f740ff740b7897965550",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart"
    },
    {
      "type": "modify",
      "old_id": "5e754ab5990c291f1ac75ac042143aca75d7750f",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/lsp/handlers/code_actions/plugins.dart",
      "new_id": "afa59a63eedc9405c467dc5076c2df0c99b5afe8",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/lsp/handlers/code_actions/plugins.dart"
    },
    {
      "type": "modify",
      "old_id": "a2da418423fd21b20e66d12d243dcdb71a6b3a0e",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/lsp/handlers/code_actions/pubspec.dart",
      "new_id": "1cd09c6260999b4159414d9f00efe9a13eac846b",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/lsp/handlers/code_actions/pubspec.dart"
    },
    {
      "type": "modify",
      "old_id": "12cd6a754bf2665e4e65167d13226aab887bb38c",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/lib/src/lsp/handlers/handler_code_actions.dart",
      "new_id": "856cbb671a8806d2adc5b28fb1aa667c08af84a5",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/lib/src/lsp/handlers/handler_code_actions.dart"
    },
    {
      "type": "modify",
      "old_id": "bccff896796f04c05dfc46fdbf2b2aa3fc69ec6f",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/code_actions_fixes_test.dart",
      "new_id": "958ef43d2c62dc8fb00babe309baee7ee1f92fce",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/code_actions_fixes_test.dart"
    },
    {
      "type": "modify",
      "old_id": "baf5eec14aaa3b8e3ad10dfd389a17bb8d22883e",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/code_actions_refactor_test.dart",
      "new_id": "ed71795bac9c46080d85f5651bb905c1a4282410",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/code_actions_refactor_test.dart"
    },
    {
      "type": "modify",
      "old_id": "ce31cf65e6cf0706a190e31288b66cd07065db6e",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/lsp/request_helpers_mixin.dart",
      "new_id": "94be420afecae0672c259cfc14b024c54de7baf2",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/lsp/request_helpers_mixin.dart"
    },
    {
      "type": "modify",
      "old_id": "0248e86476e44534163a69618b4eedf0df3dba50",
      "old_mode": 33188,
      "old_path": "pkg/analysis_server/test/utils/lsp_protocol_extensions.dart",
      "new_id": "5fabfbbd4b0158a50e7db0bda1e0eb85403ffebf",
      "new_mode": 33188,
      "new_path": "pkg/analysis_server/test/utils/lsp_protocol_extensions.dart"
    }
  ]
}