commit 3873c046389d45f70130ee75512fc7fccef4c1cd
author Ömer Sinan Ağacan <omersa@google.com> Mon Dec 11 22:21:27 2023 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Dec 11 22:21:27 2023 +0000
tree b0de2e84e75618ea976f9bf6d995d397d3e2135b
parent 208c99fca31a9d8fbf97451bd9ebc7c554c93ef9

[dart2wasm] ParamInfo documentation and minor refactoring

Change-Id: I73cdec947c3d7c5b0d1a5d2955b97273c11e1ec5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340920
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>

pkg/dart2wasm/lib/param_info.dart

diff --git a/pkg/dart2wasm/lib/param_info.dart b/pkg/dart2wasm/lib/param_info.dart
index 2d2ad28..3171d4f 100644
--- a/pkg/dart2wasm/lib/param_info.dart
+++ b/pkg/dart2wasm/lib/param_info.dart
@@ -6,12 +6,18 @@
 
 import 'package:kernel/ast.dart';
 
-/// Information about optional parameters and their default values for a
-/// member or a set of members belonging to the same override group.
+/// Information about optional parameters and their default values for a member
+/// or a set of members belonging to the same override group.
 class ParameterInfo {
   final Member? member;
   int typeParamCount = 0;
+
+  /// Default values of optional positonal parameters. `positional[i] == null`
+  /// means positional parameter `i` is not optional.
   late final List<Constant?> positional;
+
+  /// Default values of named parameters. Similar to [positional], `null` means
+  /// the the parameter is not optional.
   late final Map<String, Constant?> named;
 
   // Do not access these until the info is complete.
@@ -28,7 +34,7 @@
 
   int get paramCount => positional.length + named.length;
 
-  static Constant? defaultValue(VariableDeclaration param) {
+  static Constant? _defaultValue(VariableDeclaration param) {
     Expression? initializer = param.initializer;
     if (initializer is ConstantExpression) {
       return initializer.constant;
@@ -52,11 +58,11 @@
       positional = List.generate(function.positionalParameters.length, (i) {
         // A required parameter has no default value.
         if (i < function.requiredParameterCount) return null;
-        return defaultValue(function.positionalParameters[i]);
+        return _defaultValue(function.positionalParameters[i]);
       });
       named = {
         for (VariableDeclaration param in function.namedParameters)
-          param.name!: defaultValue(param)
+          param.name!: _defaultValue(param)
       };
     } else {
       // A setter parameter has no default value.
@@ -70,11 +76,11 @@
     positional = List.generate(function.positionalParameters.length, (i) {
       // A required parameter has no default value.
       if (i < function.requiredParameterCount) return null;
-      return defaultValue(function.positionalParameters[i]);
+      return _defaultValue(function.positionalParameters[i]);
     });
     named = {
       for (VariableDeclaration param in function.namedParameters)
-        param.name!: defaultValue(param)
+        param.name!: _defaultValue(param)
     };
   }