commit 0b94228695b74b18f6f648b1fdf50b0a1b48dd8d
author Paul Berry <paulberry@google.com> Tue Nov 02 14:23:12 2021 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Tue Nov 02 14:23:12 2021 +0000
tree 634b5fb50952f7dd86f5da97d992422254c8cd26
parent b335f28f5a8be1ef5bdb44ca1e15178de458badc

Enforce that all ErrorReporter arguments come from a limited set of types.

This change ensures that the only types ever passed to ErrorReporter
arguments are String, DartType, int, Uri, or Element.  A few call
sites had to be changed so that instead of passing in AST nodes they
passed in the result of calling `toString` on those AST nodes.

In future CLs, I plan to move toward a system where instead of passing
the message arguments to ErrorReporter as a list of `Object`, we call
a `withArguments` method that's specific to each error; that method
will have a specific list of argument types that it supports, so that
if we accidentally pass the wrong things into an error message, the
problem will be detected at compile time (instead of the user just
seeing a confusing error message).

The `withArguments` methods will be code generated from annotations in
the analyzer's `messages.yaml` file.  Keeping the set of types
supported by those `withArguments` messages small should help simplify
the code generation process, and provide flexibility for how errors
are represented in the future.

Change-Id: I4a793db2fe5b1344199b770898634b61be41ad11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216301
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>