commit 34a21f5691160c58a593d02ed73c888059d696de
author Danny Tuppeny <danny@tuppeny.com> Thu May 18 18:31:28 2023 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 18 18:31:28 2023 +0000
tree ecc6b7faaed14500408c47c7c889d79f2a3064b7
parent 2bce12b9775661d7111c77ac6a9fcccb630cf4a6

[analysis_server] Switch to using FuzzyMatcher instead of RegExp for LSP workspace symbols

See https://github.com/Dart-Code/Dart-Code/issues/4106#issuecomment-1552948926.

In my tests on the Flutter repo, this reduces the matching from around 200ms to around 40ms.

Before:
(name: request, count: 1, elapsed: 0:00:00.708230, elapsedSelf: 0:00:00.000487)
  (name: findDeclarations, count: 1, elapsed: 0:00:00.707656, elapsedSelf: 0:00:00.002735)
    (name: discoverAvailableFiles, count: 1, elapsed: 0:00:00.000187, elapsedSelf: 0:00:00.000187)
    (name: ownKnown, count: 1, elapsed: 0:00:00.023311, elapsedSelf: 0:00:00.023311)
    (name: findDeclarations, count: 1, elapsed: 0:00:00.681423, elapsedSelf: 0:00:00.016362)
      (name: getLibraryByUri, count: 7276, elapsed: 0:00:00.295596, elapsedSelf: 0:00:00.295596)
      (name: finder, count: 7272, elapsed: 0:00:00.369465, elapsedSelf: 0:00:00.055566)
        (name: addDeclaration, count: 317711, elapsed: 0:00:00.313899, elapsedSelf: 0:00:00.080608)
          (name: doNothing, count: 317711, elapsed: 0:00:00.020405, elapsedSelf: 0:00:00.020405)
          (name: regExp, count: 317711, elapsed: 0:00:00.212886, elapsedSelf: 0:00:00.212886)
  (name: convert, count: 1, elapsed: 0:00:00.000087, elapsedSelf: 0:00:00.000087)(declarations: 1)


After:
(name: request, count: 1, elapsed: 0:00:00.522033, elapsedSelf: 0:00:00.003331)
  (name: findDeclarations, count: 1, elapsed: 0:00:00.518648, elapsedSelf: 0:00:00.002939)
    (name: discoverAvailableFiles, count: 1, elapsed: 0:00:00.000213, elapsedSelf: 0:00:00.000213)
    (name: ownKnown, count: 1, elapsed: 0:00:00.021037, elapsedSelf: 0:00:00.021037)
    (name: findDeclarations, count: 1, elapsed: 0:00:00.494459, elapsedSelf: 0:00:00.016197)
      (name: getLibraryByUri, count: 7276, elapsed: 0:00:00.292021, elapsedSelf: 0:00:00.292021)
      (name: finder, count: 7272, elapsed: 0:00:00.186241, elapsedSelf: 0:00:00.050400)
        (name: addDeclaration, count: 317711, elapsed: 0:00:00.135841, elapsedSelf: 0:00:00.072235)
          (name: doNothing, count: 317711, elapsed: 0:00:00.019244, elapsedSelf: 0:00:00.019244)
          (name: isMatch, count: 317711, elapsed: 0:00:00.044362, elapsedSelf: 0:00:00.044362)
  (name: convert, count: 1, elapsed: 0:00:00.000054, elapsedSelf: 0:00:00.000054)(declarations: 1)
Change-Id: Ib8775536fb7b16b9d29c2839167ce41de9ecc874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304341
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>