)]}' { "commit": "348ed30efdd88dab74e2bddf6f4affa545ecff10", "tree": "3c62dade7c532362d77538ebbf3bdc03840e28ba", "parents": [ "c6c4748185090f5c6dcbdf4e08a54ddf61c37494" ], "author": { "name": "Vyacheslav Egorov", "email": "vegorov@google.com", "time": "Fri Sep 14 22:11:30 2018 +0000" }, "committer": { "name": "commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Fri Sep 14 22:11:30 2018 +0000" }, "message": "[vm/kernel] In async transformation check if strongMode is on.\n\nIt seems we are still using non-strong mode targets in few\nplaces (e.g. when training front-end server we by accident\ntrain it in legacy mode).\n\nA separate bug is filed to clean that up https://github.com/dart-lang/sdk/issues/34468\n\nFor now to unbreak the build we simply check if we are in the\nlegacy mode and then avoid using getStaticType in async\ntransformation.\n\nThis is followup to eec96f9076c552112ccb0b8ff3f8aa36523e9377.\n\nBug: https://github.com/dart-lang/sdk/issues/34463\nChange-Id: Ib693fddfb9abbf89599ae646cb408d4a9c93f1b6\nReviewed-on: https://dart-review.googlesource.com/75061\nCommit-Queue: Vyacheslav Egorov \u003cvegorov@google.com\u003e\nReviewed-by: Alexander Markov \u003calexmarkov@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "6638f7c31423fb807c23219f9c15357312cf7f0c", "old_mode": 33188, "old_path": "pkg/front_end/testcases/async_function.dart.direct.transformed.expect", "new_id": "d09ececadb91617e947a97836cd2b1b1e9ba72a6", "new_mode": 33188, "new_path": "pkg/front_end/testcases/async_function.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "1d8ba8fdbce273ece1e7d728998311d8850af8f0", "old_mode": 33188, "old_path": "pkg/front_end/testcases/async_nested.dart.direct.transformed.expect", "new_id": "da3a56ffd531376b01fd0749f2beae597e0cc7d2", "new_mode": 33188, "new_path": "pkg/front_end/testcases/async_nested.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "655215a5d50ae4433d4933ad97e409f45d3f199f", "old_mode": 33188, "old_path": "pkg/front_end/testcases/await.dart.direct.transformed.expect", "new_id": "7693f8c7dcec8488253c7a60cb102abd3594fe73", "new_mode": 33188, "new_path": "pkg/front_end/testcases/await.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "b27bff74228a53fe810754d87a85ef8c03b19559", "old_mode": 33188, "old_path": "pkg/front_end/testcases/bug33206.dart.direct.transformed.expect", "new_id": "b5f9c8864b7b5b9b03743923523fc1617dc9d26c", "new_mode": 33188, "new_path": "pkg/front_end/testcases/bug33206.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "a358731d5ccc5c136bcc3e4d0cc0f735e29f5bd2", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/async_await.dart.direct.transformed.expect", "new_id": "d797b5d5f4092bc1d7e937a080782618227f48c3", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/async_await.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "8e7665773f3e43a05f983649f98fe5054e0393c8", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/downwards_inference_async_await.dart.direct.transformed.expect", "new_id": "af02e8778e6d010aa86b32dcc43c89de69cb402b", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/downwards_inference_async_await.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "8bbd33f5a7d13ef9828c6c7b923495ecb5ecc760", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/downwards_inference_for_each.dart.direct.transformed.expect", "new_id": "c6a2b381bc55700fb8f4d1f62e6b3f50a1dcc6c9", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/downwards_inference_for_each.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "8ac230e0446effffaf769744e63050eea6f645d2", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/for_each_downcast_iterable.dart.direct.transformed.expect", "new_id": "46d4a06f3fd7a380d1990e029bd0abb5482b2b42", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/for_each_downcast_iterable.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "61590472b39386ac556f003dc665bd56b5df59f7", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/future_then.dart.direct.transformed.expect", "new_id": "f27ed3890a44415064afaf0bac9193bfb5986dd6", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/future_then.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "d395a357339e1918f6b183aac46a88fe9c1598f3", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/future_then_2.dart.direct.transformed.expect", "new_id": "20ee8d161add2076e20548f8795071c71e002f48", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/future_then_2.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "9131ddc92f8766503db6a242e832c4f03546a0e2", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/future_then_3.dart.direct.transformed.expect", "new_id": "c6d376627353cf9e6624584f83b4e76f923c9b72", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/future_then_3.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "9fc9fc240e7e41b90ef9bcfb0bcb93b2569278aa", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/future_then_4.dart.direct.transformed.expect", "new_id": "8f4e8cab19d118d7dbe029b711d7b5880f1bada9", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/future_then_4.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "c6b8288601bba9a5954de18412df8c5e6f023706", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/future_then_5.dart.direct.transformed.expect", "new_id": "a617678dfba45bdc0f8c6e3837f5ff0bab141214", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/future_then_5.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "8a903344d72e9659d1ca33e011de7f26ae677417", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/future_then_6.dart.direct.transformed.expect", "new_id": "925090f14b0b8c75184b55d7151cdbf2940a0401", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/future_then_6.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "4461a83140b6ebd1e7504ba92b6af58f7006d71f", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_future_return.dart.direct.transformed.expect", "new_id": "89b8af907dc66f75bcbd978af344d52a7e4f165b", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_future_return.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "ebe93d902670702bd20cf0a93b226cef2406043b", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/future_union_upwards_generic_methods.dart.direct.transformed.expect", "new_id": "7bc149c3fcbb4c32f5dc426f747e9a24f5efd9c2", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/future_union_upwards_generic_methods.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "dfe553112e47bb10446fefa562dbe69fae5a70a9", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_each_loop_async.dart.direct.transformed.expect", "new_id": "8c8c2947498e95daa04b28d2eca83a5f0ee23762", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_each_loop_async.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "547f6412a1e3a59bfd4f3343de5fd188e6edc79a", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference_new/for_each_invalid_iterable.dart.direct.transformed.expect", "new_id": "3eefc915dac24f560df6d0445269ffcf55c153f7", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference_new/for_each_invalid_iterable.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "c914a79999fe6a650d4ac1410fae603015724116", "old_mode": 33188, "old_path": "pkg/front_end/testcases/inference_new/for_each_outer_var_type.dart.direct.transformed.expect", "new_id": "1c7200bb241afde80c5f47f4366f93c15ac59efb", "new_mode": 33188, "new_path": "pkg/front_end/testcases/inference_new/for_each_outer_var_type.dart.direct.transformed.expect" }, { "type": "modify", "old_id": "e3db3b522fa814d29fbcac8bd2e6625f178cbb3b", "old_mode": 33261, "old_path": "pkg/kernel/bin/transform.dart", "new_id": "d04dda3084b081d37284d3502861e9bfa5f7cbf7", "new_mode": 33261, "new_path": "pkg/kernel/bin/transform.dart" }, { "type": "modify", "old_id": "4050e07cf36fb1f01cb7970ece45b0f568775fe6", "old_mode": 33188, "old_path": "pkg/kernel/lib/transformations/async.dart", "new_id": "0d29e7eba5e564af2630cb7f44ac0889ad375d47", "new_mode": 33188, "new_path": "pkg/kernel/lib/transformations/async.dart" }, { "type": "modify", "old_id": "fd06825820565f39f58c45e43b4b6bd943cfc703", "old_mode": 33188, "old_path": "pkg/kernel/lib/transformations/continuation.dart", "new_id": "56c03a9b70f0680fdade09fd12d40020f38b6f00", "new_mode": 33188, "new_path": "pkg/kernel/lib/transformations/continuation.dart" }, { "type": "modify", "old_id": "f67260e7c66fda1c419714f9069426e59d6ade0e", "old_mode": 33188, "old_path": "pkg/vm/lib/target/vm.dart", "new_id": "71b799a8206c1cc6f527b94f272028f367b53e10", "new_mode": 33188, "new_path": "pkg/vm/lib/target/vm.dart" } ] }