commit 326f0b26748906cc278c79554ad4feccb51e8b0a
author Stephen Adams <sra@google.com> Mon Feb 07 19:34:26 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Mon Feb 07 19:34:26 2022 +0000
tree ea1e212193bafd4744560540bf0f9698894fa4a7
parent 3c16fdd3b019e9e60d5c23bbb77a0faf0a7bec7b

[js_runtime] Avoid crash printing tear-off on `null`

TEST: https://dart-review.googlesource.com/c/sdk/+/231845

Fixed: 48322
Change-Id: I8a89e7b771f63905bb25594a7e2721d4a7e3ee62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231847
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Stephen Adams <sra@google.com>

sdk/lib/_internal/js_runtime/lib/js_helper.dart

diff --git a/sdk/lib/_internal/js_runtime/lib/js_helper.dart b/sdk/lib/_internal/js_runtime/lib/js_helper.dart
index 7e44673..f0ecaa5 100644
--- a/sdk/lib/_internal/js_runtime/lib/js_helper.dart
+++ b/sdk/lib/_internal/js_runtime/lib/js_helper.dart
@@ -397,7 +397,7 @@
   /// In minified mode, uses the unminified names if available, otherwise tags
   /// them with 'minified:'.
   @pragma('dart2js:noInline')
-  static String objectTypeName(Object object) {
+  static String objectTypeName(Object? object) {
     return _objectTypeNameNewRti(object);
   }
 
@@ -406,7 +406,7 @@
   ///
   /// In minified mode, uses the unminified names if available, otherwise tags
   /// them with 'minified:'.
-  static String _objectTypeNameNewRti(Object object) {
+  static String _objectTypeNameNewRti(Object? object) {
     var dartObjectConstructor = JS_BUILTIN(
         'depends:none;effects:none;', JsBuiltin.dartObjectConstructor);
     if (JS('bool', '# instanceof #', object, dartObjectConstructor)) {
@@ -452,7 +452,7 @@
       name != null && name != 'Object' && name != '';
 
   /// In minified mode, uses the unminified names if available.
-  static String objectToHumanReadableString(Object object) {
+  static String objectToHumanReadableString(Object? object) {
     String name = objectTypeName(object);
     return "Instance of '$name'";
   }