commit 309d9ceff1bb4957ce0badc26883d1e8fb009b23
author pq <pquitslund@google.com> Thu Oct 27 19:17:08 2022 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 27 19:17:08 2022 +0000
tree 484edce857e54b87a20331167f93261f8013a5d9
parent 700b94eb04170873d19054aa39300df6c9452759

stop bulk-fixing `hash_and_equals`

Change-Id: Iada0e09677c11bec15c360821298c3735dde9d4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266280
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>

pkg/analysis_server/lib/src/services/correction/dart/create_method.dart

diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_method.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_method.dart
index 4ef6f5a..4b16723 100644
--- a/pkg/analysis_server/lib/src/services/correction/dart/create_method.dart
+++ b/pkg/analysis_server/lib/src/services/correction/dart/create_method.dart
@@ -30,7 +30,7 @@
   /// pair.
   CreateMethod.equalsOrHashCode()
       : _kind = _MethodKind.equalsOrHashCode,
-        canBeAppliedInBulk = true,
+        canBeAppliedInBulk = false,
         canBeAppliedToFile = true;
 
   /// Initialize a newly created instance that will create a method based on an

pkg/analysis_server/test/src/services/correction/fix/create_method_test.dart

diff --git a/pkg/analysis_server/test/src/services/correction/fix/create_method_test.dart b/pkg/analysis_server/test/src/services/correction/fix/create_method_test.dart
index 2add22c..1f769ff 100644
--- a/pkg/analysis_server/test/src/services/correction/fix/create_method_test.dart
+++ b/pkg/analysis_server/test/src/services/correction/fix/create_method_test.dart
@@ -12,7 +12,6 @@
 
 void main() {
   defineReflectiveSuite(() {
-    defineReflectiveTests(AddMissingHashOrEqualsBulkTest);
     defineReflectiveTests(AddMissingHashOrEqualsTest);
     defineReflectiveTests(CreateMethodMixinTest);
     defineReflectiveTests(CreateMethodTest);
@@ -20,48 +19,6 @@
 }
 
 @reflectiveTest
-class AddMissingHashOrEqualsBulkTest extends BulkFixProcessorTest {
-  @override
-  String get lintCode => LintNames.hash_and_equals;
-
-  Future<void> test_singleFile() async {
-    await resolveTestCode('''
-class C {
-  @override
-  int get hashCode => 13;
-}
-
-class D {
-  @override
-  bool operator ==(Object other) => false;
-}
-''');
-    await assertHasFix('''
-class C {
-  @override
-  int get hashCode => 13;
-
-  @override
-  bool operator ==(Object other) {
-    // TODO: implement ==
-    return super == other;
-  }
-}
-
-class D {
-  @override
-  bool operator ==(Object other) => false;
-
-  @override
-  // TODO: implement hashCode
-  int get hashCode => super.hashCode;
-
-}
-''');
-  }
-}
-
-@reflectiveTest
 class AddMissingHashOrEqualsTest extends FixProcessorLintTest {
   @override
   FixKind get kind => DartFixKind.CREATE_METHOD;