[messages] Remove broken message_coverage_test.dart.
Removes the tests in `message_coverage_test.dart`, which have been
failing since 2017. These tests were part of a previous effort to
unify analyzer and CFE error codes, and are no longer needed. Removing
them will make it easier to clean up and refactor the logic for
handling shared error codes.
Change-Id: I6a6a696405dbbab1934f39294c89c0ed22c23395
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451860
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
diff --git a/pkg/analyzer/test/src/fasta/message_coverage_test.dart b/pkg/analyzer/test/src/fasta/message_coverage_test.dart
deleted file mode 100644
index bf2f0b6..0000000
--- a/pkg/analyzer/test/src/fasta/message_coverage_test.dart
+++ /dev/null
@@ -1,198 +0,0 @@
-// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import 'dart:io' as io;
-
-import 'package:analyzer/dart/ast/ast.dart';
-import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer_testing/package_root.dart' as package_root;
-import 'package:analyzer_utilities/messages.dart';
-import 'package:path/path.dart' as path;
-import 'package:test/test.dart';
-import 'package:test_reflective_loader/test_reflective_loader.dart';
-
-import '../../generated/parser_test_base.dart';
-
-main() {
- defineReflectiveSuite(() {
- defineReflectiveTests(AbstractRecoveryTest);
- });
-}
-
-@reflectiveTest
-class AbstractRecoveryTest extends FastaParserTestCase {
- /// Given the path to the file containing the declaration of the fasta Parser,
- /// return a set containing the names of all the messages and templates that
- /// are referenced (presumably because they are being generated) within that
- /// file.
- Set<String> getGeneratedNames(String parserPath) {
- String content = io.File(parserPath).readAsStringSync();
- CompilationUnit unit = parseCompilationUnit(content);
- expect(unit, isNotNull);
- GeneratedCodesVisitor visitor = GeneratedCodesVisitor();
- unit.accept(visitor);
- return visitor.generatedNames;
- }
-
- /// Return a list of the front end messages that define an 'analyzerCode'.
- List<String> getMappedCodes() {
- Set<String> codes = <String>{};
- for (var entry in frontEndAndSharedMessages.entries) {
- var name = entry.key;
- var errorCodeInfo = entry.value;
- if (errorCodeInfo.analyzerCodes.isNotEmpty) {
- codes.add(name);
- }
- }
- return codes.toList();
- }
-
- /// Return a list of the analyzer codes defined in the front end's
- /// `messages.yaml` file.
- List<String> getReferencedCodes() {
- Set<String> codes = <String>{};
- for (var errorCodeInfo in frontEndAndSharedMessages.values) {
- codes.addAll(errorCodeInfo.analyzerCodes);
- }
- return codes.toList();
- }
-
- /// Given the path to the file containing the declaration of the AstBuilder,
- /// return a list of the analyzer codes that are translated by the builder.
- List<String> getTranslatedCodes(String astBuilderPath) {
- String content = io.File(astBuilderPath).readAsStringSync();
- CompilationUnit unit = parseCompilationUnit(content);
- var astBuilder = unit.declarations[0] as ClassDeclaration;
- var method = astBuilder.members.whereType<MethodDeclaration>().firstWhere(
- (x) => x.name.lexeme == 'reportMessage',
- );
- SwitchStatement statement = (method.body as BlockFunctionBody)
- .block
- .statements
- .whereType<SwitchStatement>()
- .first;
- expect(statement, isNotNull);
- List<String> codes = <String>[];
- for (SwitchMember member in statement.members) {
- if (member is SwitchCase) {
- codes.add((member.expression as StringLiteral).stringValue!);
- }
- }
- return codes;
- }
-
- @failingTest
- test_mappedMessageCoverage() {
- String frontEndPath = path.join(package_root.packageRoot, 'front_end');
- String parserPath = path.join(
- frontEndPath,
- 'lib',
- 'src',
- 'fasta',
- 'parser',
- 'parser.dart',
- );
- Set<String> generatedNames = getGeneratedNames(parserPath);
-
- List<String> mappedCodes = getMappedCodes();
-
- generatedNames.removeAll(mappedCodes);
- if (generatedNames.isEmpty) {
- return;
- }
- List<String> sortedNames = generatedNames.toList()..sort();
- StringBuffer buffer = StringBuffer();
- buffer.writeln('Generated parser errors without analyzer codes:');
- for (String name in sortedNames) {
- buffer.write(' ');
- buffer.writeln(name);
- }
- fail(buffer.toString());
- }
-
- @failingTest
- test_translatedMessageCoverage() {
- String analyzerPath = path.join(package_root.packageRoot, 'analyzer');
- String astBuilderPath = path.join(
- analyzerPath,
- 'lib',
- 'src',
- 'fasta',
- 'error_converter.dart',
- );
- List<String> translatedCodes = getTranslatedCodes(astBuilderPath);
-
- List<String> referencedCodes = getReferencedCodes();
-
- List<String> untranslated = <String>[];
- for (String referencedCode in referencedCodes) {
- if (!translatedCodes.contains(referencedCode)) {
- untranslated.add(referencedCode);
- }
- }
- StringBuffer buffer = StringBuffer();
- if (untranslated.isNotEmpty) {
- buffer.writeln(
- 'Analyzer codes used in messages.yaml but not translated:',
- );
- for (String code in untranslated) {
- buffer.write(' ');
- buffer.writeln(code);
- }
- buffer.write(
- 'Add a case for these codes to FastaErrorReporter.reportError.',
- );
- }
-
- List<String> unreferenced = <String>[];
- for (String translatedCode in translatedCodes) {
- if (!referencedCodes.contains(translatedCode)) {
- unreferenced.add(translatedCode);
- }
- }
- if (untranslated.isNotEmpty) {
- if (buffer.isNotEmpty) {
- buffer.writeln();
- buffer.writeln();
- }
- buffer.writeln(
- 'Analyzer codes that are translated but not used in messages.yaml:',
- );
- for (String code in unreferenced) {
- buffer.write(' ');
- buffer.writeln(code);
- }
- buffer.write(
- 'Remove the cases for these codes from '
- 'FastaErrorReporter.reportMessage.',
- );
- }
- if (buffer.isNotEmpty) {
- fail(buffer.toString());
- }
- }
-}
-
-/// A visitor that gathers the names of all the message codes that are generated
-/// in the visited AST. This assumes that the codes are accessed via the prefix
-/// 'fasta'.
-class GeneratedCodesVisitor extends RecursiveAstVisitor {
- /// The names of the message codes that are generated in the visited AST.
- Set<String> generatedNames = <String>{};
-
- @override
- visitPrefixedIdentifier(PrefixedIdentifier node) {
- if (node.prefix.name == 'fasta') {
- String name = node.identifier.name;
- if (name.startsWith('message')) {
- name = name.substring(7);
- } else if (name.startsWith('template')) {
- name = name.substring(8);
- } else {
- return;
- }
- generatedNames.add(name);
- }
- }
-}
diff --git a/pkg/analyzer/test/src/fasta/test_all.dart b/pkg/analyzer/test/src/fasta/test_all.dart
index adb1d99..bd4b08c 100644
--- a/pkg/analyzer/test/src/fasta/test_all.dart
+++ b/pkg/analyzer/test/src/fasta/test_all.dart
@@ -5,14 +5,12 @@
import 'package:test_reflective_loader/test_reflective_loader.dart';
import 'ast_builder_test.dart' as ast_builder;
-import 'message_coverage_test.dart' as message_coverage;
import 'recovery/test_all.dart' as recovery;
import 'token_utils_test.dart' as token_utils;
main() {
defineReflectiveSuite(() {
ast_builder.main();
- message_coverage.main();
recovery.main();
token_utils.main();
}, name: 'fasta');
