commit 2e87f8c95a699bdcd672c7fbd4e3083faba3220f
author Daco Harkes <dacoharkes@google.com> Wed Jul 26 16:02:56 2023 +0000
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jul 26 16:02:56 2023 +0000
tree 28fbf87638249dbe7795bf4b79b0ca9e5ef3a0ab
parent 66df28dcc6db1a8a9e75eefc6076945c0494d199

[tools] Fixes to find_builders.dart

Fixes the Gerrit CL footer.

Denylists some builders which are not available on CQ but only on CI.

Change-Id: Ie0716c52366a8be429c2b6aca030e61769ceca80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316382
Reviewed-by: William Hesse <whesse@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>

tools/find_builders.dart

diff --git a/tools/find_builders.dart b/tools/find_builders.dart
index a6f3d9a..8c4157a 100755
--- a/tools/find_builders.dart
+++ b/tools/find_builders.dart
@@ -27,12 +27,13 @@
     for (final testName in testNames) ...await _testGetConfigurations(testName),
   });
   final configurationBuilders = await _configurationBuilders();
-  final builders = {
-    for (final config in configurations) configurationBuilders[config]
-  }.toList()
+  final builders = _filterBuilders(
+    {for (final config in configurations) configurationBuilders[config]!},
+  ).toList()
     ..sort();
 
-  print('Cq-Include-Trybots: luci.dart.try:${builders.join(',')}');
+  final gerritTryList = builders.map((b) => '$b-try').join(',');
+  print('Cq-Include-Trybots: luci.dart.try:$gerritTryList');
 }
 
 Future<List<String>> _testGetConfigurations(String testName) async {
@@ -73,9 +74,18 @@
   return result..sort();
 }
 
+Iterable<String> _filterBuilders(Iterable<String> builders) {
+  return builders.where((b) => !_ciOnlyBuilders.contains(b));
+}
+
+const _ciOnlyBuilders = {
+  'vm-aot-linux-release-arm64',
+  'vm-linux-release-arm64',
+};
+
 Stream<Map<String, dynamic>> _configurationDocuments() async* {
   String? nextPageToken;
-  while (true) {
+  do {
     final requestUrl = Uri(
       scheme: 'https',
       host: 'firestore.googleapis.com',
@@ -91,10 +101,7 @@
         object['documents'].cast<Map<String, dynamic>>());
 
     nextPageToken = object['nextPageToken'];
-    if (nextPageToken == null) {
-      break;
-    }
-  }
+  } while (nextPageToken != null);
 }
 
 Future<Map<String, String>> _configurationBuilders() async {