| commit | 2ca08ef2e1697edc3a0e99e21121f9de12ae79e3 | [log] [tgz] |
|---|---|---|
| author | Jonas Termansen <sortie@google.com> | Fri Nov 30 17:08:04 2018 +0000 |
| committer | Jonas Termansen <sortie@google.com> | Fri Nov 30 17:08:04 2018 +0000 |
| tree | 5ee34497ff344a36e77128d280014622913c2ac6 | |
| parent | f72f07793bc78c2217ba2c613cbc25f5fe2f201d [diff] |
[infra] Implement preapproval of failing tests in approve_results. This change lets committers preapprove new failing tests based on commit queue / dry run results for CQ builders, such that the CQ builder stays green when the change is submitted. The current implementation does not support changing one test from a failing mode to another failing mode. It will work, but if the corresponding CI builder cycles before the changelist is submitted, it will become red until the changelist is submitted. This will be addressed in the future. Likewise approving a builder after a preapproval will undo the preapproval unless the changelist has been submitted and the corresponding CI builder has cycled. Bug: https://github.com/dart-lang/sdk/issues/35289 Change-Id: Ie43df4439a27a3472c5178cb7c6af69292cf70e4 Reviewed-on: https://dart-review.googlesource.com/c/85601 Reviewed-by: William Hesse <whesse@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.