Improve the way we call inferExpression

This function took a boolean flag typeNeeded and then it had an early
exit guarded by the condition (!typeNeeded && isTopLevel).  That is, a
false value for typeNeeded was just ignored when isTopLevel was false.

Change it so the early exit is only guarded by the value of the
argument, and ensure that the intended value is passed at all the call
sites.  This makes it easier to see under which conditions we are and
are not peforming type inference.

This is a prelimary step to simply not performing any inference when
we don't intend to perform any inference.

Change-Id: Ibe2260aa4967250afb8b23899216ae32c5321183
Reviewed-on: https://dart-review.googlesource.com/c/80667
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
4 files changed
tree: 8341f7233407053e6983adfb2f54bcc4bb635c90
  1. .clang-format
  2. .gitattributes
  3. .gitconfig
  4. .github/
  5. .gitignore
  6. .gn
  7. .mailmap
  8. .packages
  9. .vpython
  10. AUTHORS
  11. BUILD.gn
  12. CHANGELOG.md
  13. CONTRIBUTING.md
  14. DEPS
  15. LICENSE
  16. PATENTS
  17. PRESUBMIT.py
  18. README.dart-sdk
  19. README.md
  20. WATCHLISTS
  21. build/
  22. client/
  23. codereview.settings
  24. dartdoc_options.yaml
  25. docs/
  26. pkg/
  27. runtime/
  28. samples-dev/
  29. samples/
  30. sdk/
  31. tests/
  32. third_party/
  33. tools/
  34. utils/
README.md

Dart

Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.

Using Dart

Visit the dartlang.org to learn more about the language, tools, getting started, and more.

Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents on our wiki.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.

License & patents

See LICENSE and PATENTS.