| commit | 2b13268c8eaa870517749e997d4be6d387e4f17e | [log] [tgz] |
|---|---|---|
| author | Konstantin Shcheglov <scheglov@google.com> | Tue Sep 09 08:23:12 2025 -0700 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Sep 09 08:23:12 2025 -0700 |
| tree | 50bd68f66efd60fe072a0e984aa12b7b3e3387da | |
| parent | fc1bd94daaf72c3a6f88d9385462428a612056e1 [diff] |
Fine. Track constructor/method/top-level function APIs.
Fine-grained dependency tracking missed several element APIs and edge
cases. This change annotates and records usage of key properties on
`ConstructorElementImpl`, `MethodElementImpl`, and
`TopLevelFunctionElementImpl`, and extends the manifest/serialization to
capture relationships and inference state that affect API shape.
What’s included
- Add `@elementClass` and granular tracking on members:
- Mark identifiers and flags with `@trackedIncludedInId`.
- Mark getters like `firstFragment`, `fragments`, `lastFragment`,
`accept()`, `visitChildren()` as `@trackedDirectlyOpaque` and record
opaque API use.
- Mark derived properties as `@trackedIndirectly` and internal caches
as `@trackedInternal`.
- Expose `_fragments` lists so tracked access doesn’t bypass recording.
- Constructors:
- Track `isConst`, `isFactory`, `constantInitializers`.
- Persist and match `redirectedConstructor` and `superConstructor`
via new optional `ManifestElement` fields.
- Compute `isGenerative` as `!isFactory` to avoid fragment drift.
- Methods:
- Persist `isOperatorEqualWithParameterTypeFromObject`.
- Serialize `typeInferenceError` and surface it in manifests.
- Add binary I/O for `TopLevelInferenceError` (read/write/optional,
equality) and print it in result output.
- Extend `ManifestElement` with `encodeOptional()/readOptional()` and a
helper extension for matching/writing optionals.
- Update the result printer to show:
- Method flags and optional `typeInferenceError`.
- Constructor `redirectedConstructor` and `superConstructor`.
- Bump `AnalysisDriver.DATA_VERSION` to 547 to invalidate old caches.
- Minor fixes:
- Use `baseElement.firstFragmentLocation.libraryFragment!.source` when
wiring the diagnostic reporter in constant evaluation to align with
fragment locations.
Why
Clients of the fine-grained dependency system rely on accurate
identification and usage tracking of element APIs. Missing tracking for
fragments/visitors and absent manifest fields (constructor redirection/
super calls, method inference errors) could let incompatible API changes
slip past invalidation and requirement checks. Persisting these details
ensures correct cache keys, precise requirement verification, and more
actionable diagnostics.
Compatibility
- Data/summary format changes require a cache rebuild (version 547).
- No user-visible API changes.
Change-Id: Ifdc1a97e87dc6e2decabcf0d9a9c634825da6e85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448900
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.