)]}'
{
  "commit": "2b06ac466d322c7bbcd3116a688ddbfa05e2adb0",
  "tree": "3289f8cff338028e8c6c839452fb13682864f1d9",
  "parents": [
    "fabbac4afd96ed177abbd9806ae79e1a48ed2c37"
  ],
  "author": {
    "name": "Paul Berry",
    "email": "paulberry@google.com",
    "time": "Mon Aug 22 22:59:26 2022 +0000"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Mon Aug 22 22:59:26 2022 +0000"
  },
  "message": "Flow analysis: rework some testing logic in preparation for pattern support.\n\n- Variable types are no longer specified in the call to the `Var`\n  constructor; they are now specified in the call to `declare`.  This\n  paves the way for supporting variable pattern syntax, in which a\n  single variable might appear in multiple variable patterns, and have\n  its type specified in each pattern.  The properties `isFinal` and\n  `isLate` are also moved to `declare` for consistency.\n\n- Variables with inferred types are now specified by simply not\n  including a type in `declare`; it\u0027s no longer necessary to specify\n  `isImplicitlyTyped: true`.\n\n- `declare` now supports an `expectInferredType` argument to allow the\n  inferred type of an implicitly typed variable to be tested.\n\n- The tests now check that variables are assigned a type before flow\n  analysis requests it; previously this was not tested, and the flow\n  analysis tests sometimes did things in the wrong order.  (The\n  analyzer and CFE have always done this in the proper order though).\n\n- The tests now support some of the crazy types that arise during type\n  parameter promotion, e.g. they can now distinguish `(T\u0026int)?` from\n  `T\u0026(int?)`.\n\n- Flow analysis tests now properly replicate the analyzer and CFE\n  behaviors for converting the static type of an initializer\n  expression to the corresponding inferred variable type: (a) `Null`\n  is converted to `dynamic`, and (b) type parameter promotions are\n  dropped.\n\nNote that this last behavior (dropping type parameter promotions) has\na lot of subtleties, and I\u0027m not convinced the CFE and analyzer do it\nsoundly in all cases (I\u0027ve already found one such soundness bug:\nhttps://github.com/dart-lang/sdk/issues/49691).  In a later CL, I plan\nto add a more thorough set of language tests to verify that we don\u0027t\nhave other lurking soundness issues.\n\nChange-Id: I6f2cd20db1f07b34e0ad4e7002351c8de846b125\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/255600\nReviewed-by: Konstantin Shcheglov \u003cscheglov@google.com\u003e\nCommit-Queue: Paul Berry \u003cpaulberry@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "0c74d83679d1c171c23087bfe456dabbefab8a57",
      "old_mode": 33188,
      "old_path": "pkg/_fe_analyzer_shared/test/flow_analysis/flow_analysis_test.dart",
      "new_id": "14c510fd7ef7adf80767fa368afdfd129691b5b6",
      "new_mode": 33188,
      "new_path": "pkg/_fe_analyzer_shared/test/flow_analysis/flow_analysis_test.dart"
    },
    {
      "type": "modify",
      "old_id": "304364e9c21027156a18558e7f8ba37448cfd319",
      "old_mode": 33188,
      "old_path": "pkg/_fe_analyzer_shared/test/mini_ast.dart",
      "new_id": "7c87ad61239acc165d6aa82222dd0c039153423c",
      "new_mode": 33188,
      "new_path": "pkg/_fe_analyzer_shared/test/mini_ast.dart"
    },
    {
      "type": "modify",
      "old_id": "12546f07f47a8513579828b82ddd9fbfb72267ee",
      "old_mode": 33188,
      "old_path": "pkg/_fe_analyzer_shared/test/mini_types.dart",
      "new_id": "e80e95b74d1d925d9d7fd236123a5e3cb3db5d77",
      "new_mode": 33188,
      "new_path": "pkg/_fe_analyzer_shared/test/mini_types.dart"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "0cc40e4fe55d1a9d8e4c541381413c705be4fa64",
      "new_mode": 33188,
      "new_path": "pkg/_fe_analyzer_shared/test/mini_types_test.dart"
    }
  ]
}