commit 25cf5e484635ad083071145914dea8f7d09a02c9
author Paul Berry <paulberry@google.com> Tue Sep 16 07:02:53 2025 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 16 07:02:53 2025 -0700
tree d21f2803ca2ac9445e76d15dc74541708a2d1342
parent 6abae965db5d4d4e502195da01549de65f616754

[messages] Make derived classes for CfeStyleErrorCodeInfo.

Changes `CfeStyleErrorCodeInfo` to an abstract class and makes two
derived classes with additional integrity checks:

- `FrontEndErrorCodeInfo`, to represent error codes from
  `pkg/front_end/messages.yaml`. The constructor for this class checks
  that the message doesn't have an `index` field (because messages
  with an `index` field are meant to be shared, and thus should go in
  `pkg/_fe_analyzer_shared/messages.yaml`).

- `SharedErrorCodeInfo`, to represent error codes from
  `pkg/_fe_analyzer_shared/messages.yaml`. The constructor for this
  class checks that the message _does_ have an `index` field, and also
  checks that its `analyzerCode` field contains exactly one entry
  (this is important because it determines the name of the analyzer
  error that will be generated from the shared error definition).

Also, renames `CfeStyleErrorCodeInfo.analyzerCode` to `analyzerCodes`
(since, in general, there may be more than one associated analyzer
error code) and adds `SharedErrorCodeInfo.analyzerCode` to fetch the
one analyzer error code associated with a shared error.

These changes have the effect of baking the assumptions about front
end and shared error codes into the type system, which should make it
easier to write code that depends on those assumptions. In follow-up
CLs, I plan to modify the code generation logic in ways that rely more
heavily on these assumptions, and having them baked into the type
system will make that more straight forward.

Change-Id: I6a6a696444ae6695cc9548cb087488a4464e4777
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449605
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>