| commit | 25169313d955165035d55433012f84afe975504c | [log] [tgz] |
|---|---|---|
| author | Ömer Sinan Ağacan <omersa@google.com> | Mon Jul 15 11:27:32 2024 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jul 15 11:27:32 2024 +0000 |
| tree | 6bd8befb270840a36e9479372ef2f5e58897a645 | |
| parent | b5ecb576ed9913202d608adf88b2ac5c88acfa7c [diff] |
[dart2wasm] Avoid compiler crash when casting unboxed types When omitting checks, casts between unboxed types currently cause a compile-time crash when generating the conversion. This compile-time crash is useful to catch compiler errors, but when the checks are omitted it can be triggered on invalid casts, such as when casting a `double` to `int`. So when omitting checks, generate an `unreachable` (consistent with other type cast failure when omitting checks) instead of crashing. An alterantive implementation (see patchset 1) would be checking for cast failures when compiling `as` expressions with omitted checks. However it makes the code slightly more complicated, and more importantly `unreachable` gets a wrong source span as it's generated after the `wrap` to compile expression. Fixes #56234. Change-Id: Ia93a850d028a69320ff671efd8344843fa7c4388 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375640 Commit-Queue: Ömer Ağacan <omersa@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.