commit 20ed5e0dc61b2a860c4f2f858dfda234eb7b34b0
author Sigmund Cherem <sigmund@google.com> Thu Jan 27 21:13:41 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Jan 27 21:13:41 2022 +0000
tree 07592c7b250424f59df44aa0b113edd43daed6ae
parent 6f917703d323f23933ddce47c9df6b06165eaeee

[test_runner]: cleanup on Dart2jsCompilationCommand

Changes are:
* remove case in createOutput, this is unreachable and
  now handled by the subclass
* remove "|| true" - it was meant for debugging and I forgot
  to delete it.

Change-Id: I32dbc34ec51c02c9f311fa1b3a246b3cb73db194
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229380
Reviewed-by: Alexander Thomas <athom@google.com>

pkg/test_runner/lib/src/command.dart

diff --git a/pkg/test_runner/lib/src/command.dart b/pkg/test_runner/lib/src/command.dart
index c14af03..690b1d1 100644
--- a/pkg/test_runner/lib/src/command.dart
+++ b/pkg/test_runner/lib/src/command.dart
@@ -186,9 +186,6 @@
     if (displayName == 'precompiler' || displayName == 'app_jit') {
       return VMCommandOutput(
           this, exitCode, timedOut, stdout, stderr, time, pid);
-    } else if (displayName == 'dart2js') {
-      return Dart2jsCompilerCommandOutput(
-          this, exitCode, timedOut, stdout, stderr, time, compilationSkipped);
     } else if (displayName == 'dartdevc') {
       return DevCompilerCommandOutput(this, exitCode, timedOut, stdout, stderr,
           time, compilationSkipped, pid);
@@ -263,7 +260,7 @@
       int index = 0})
       : super("dart2js", outputFile, bootstrapDependencies, executable,
             arguments, environmentOverrides,
-            alwaysCompile: alwaysCompile || true,
+            alwaysCompile: alwaysCompile,
             workingDirectory: workingDirectory,
             index: index);