[analyzer] Re-enable removed_lint_use and replaced_lint_use tests.

These tests were disabled in
https://dart-review.googlesource.com/c/sdk/+/280218, when the logic
for reporting `replaced_lint_use` and `removed_lint_use` was
temporarily disabled. Later, when this logic was re-enabled in
https://dart-review.googlesource.com/c/sdk/+/404480, the tests weren't
re-enabled (presumably due to an oversight).

It turns out that the tests were a little stale, so as part of
re-enabling them I've made the following updates:

- I adjusted the tests so that they enable the lint
  `unnecessary_ignore`. See
  https://github.com/dart-lang/sdk/issues/62040 for why this is
  necessary.

- I changed the `removed_lint_use` tests to that they test using an
  actual removed lint rather than a synthetic lint. This reduces the
  risk of accidentally breaking this functionality.

- I changed the `replaced_lint_use` tests so that they synthetic lints
  they use contain a proper non-throwing implementation of the
  `diagnosticCode` getter. This is necessary because when a lint is
  registered, `Registry.registerLintRule` iterates through all of the
  rule's diagnostic codes and uses them to populate
  `Registry._codeMap` (a table mapping unique names to diagnostic
  codes). Note that it wasn't possible to change the
  `replaced_lint_use` tests to use an actual replaced lint, because
  there are no actual replaced lints.

This paves the way for follow-up CLs in which I plan to rework the
mechanism for reporting `removed_lint_use` and `replaced_lint_use`
warnings.

Change-Id: I6a6a696449152c080df1099283a2e023b12bb78d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/463161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2 files changed
tree: 476179e0f03756f007538fe25d723fdb52ce556c
  1. .dart_tool/
  2. .github/
  3. benchmarks/
  4. build/
  5. docs/
  6. pkg/
  7. runtime/
  8. samples/
  9. sdk/
  10. tests/
  11. third_party/
  12. tools/
  13. utils/
  14. .clang-format
  15. .gitattributes
  16. .gitconfig
  17. .gitignore
  18. .gn
  19. .mailmap
  20. .style.yapf
  21. AUTHORS
  22. BUILD.gn
  23. CHANGELOG.md
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. OWNERS
  29. PATENT_GRANT
  30. PRESUBMIT.py
  31. pubspec.yaml
  32. README.dart-sdk
  33. README.md
  34. sdk.code-workspace
  35. sdk_args.gni
  36. sdk_packages.yaml
  37. SECURITY.md
  38. WATCHLISTS
README.md

Dart

An approachable, portable, and productive language for high-quality apps on any platform

Dart is:

  • Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.

  • Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.

Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit dart.dev to learn more about the language, tools, and to find codelabs.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents in our repo at docs.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.

Roadmap

Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.