commit 1d5b271fe0567ae37b14d914d99a1a9e54476eab
author Keerti Parthasarathy <keertip@google.com> Mon Jul 07 08:32:33 2025 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 07 08:32:33 2025 -0700
tree b574b3788be24095044caa852c4916f076963ea6
parent d3c323e26d1663ab422ff89b65d5a78b0e89c997

[Completion]Do not suggest constructors if element is not visible.

Change-Id: Ic5ebec233199a6d9cf0faf370ac3114bc0251b32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/438580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>

pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart b/pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
index b28e8c9..e9ec9b5 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
@@ -1831,6 +1831,18 @@
     if (mustBeAssignable) {
       return;
     }
+    if (checkVisibilty &&
+        !visibilityTracker.isVisible(
+          element: constructors.first.enclosingElement,
+          importData: importData,
+        )) {
+      return;
+    }
+
+    if (checkVisibilty) {
+      checkVisibilty = false;
+    }
+
     for (var constructor in constructors) {
       if (constructor.isVisibleIn(request.libraryElement) &&
           (allowNonFactory || constructor.isFactory)) {

pkg/analysis_server/test/services/completion/dart/completion_test.dart

diff --git a/pkg/analysis_server/test/services/completion/dart/completion_test.dart b/pkg/analysis_server/test/services/completion/dart/completion_test.dart
index cc27ccb..837974e 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_test.dart
@@ -4881,18 +4881,6 @@
 suggestions
   Map
     kind: constructorInvocation
-  Map.from
-    kind: constructorInvocation
-  Map.fromEntries
-    kind: constructorInvocation
-  Map.fromIterable
-    kind: constructorInvocation
-  Map.fromIterables
-    kind: constructorInvocation
-  Map.identity
-    kind: constructorInvocation
-  Map.unmodifiable
-    kind: constructorInvocation
 ''');
   }
 
@@ -4905,18 +4893,6 @@
 suggestions
   Map
     kind: constructorInvocation
-  Map.from
-    kind: constructorInvocation
-  Map.fromEntries
-    kind: constructorInvocation
-  Map.fromIterable
-    kind: constructorInvocation
-  Map.fromIterables
-    kind: constructorInvocation
-  Map.identity
-    kind: constructorInvocation
-  Map.unmodifiable
-    kind: constructorInvocation
 ''');
   }
 
@@ -4929,18 +4905,6 @@
 suggestions
   Map
     kind: constructorInvocation
-  Map.from
-    kind: constructorInvocation
-  Map.fromEntries
-    kind: constructorInvocation
-  Map.fromIterable
-    kind: constructorInvocation
-  Map.fromIterables
-    kind: constructorInvocation
-  Map.identity
-    kind: constructorInvocation
-  Map.unmodifiable
-    kind: constructorInvocation
 ''');
   }
 
@@ -5372,10 +5336,6 @@
 suggestions
   List
     kind: constructorInvocation
-  List.empty
-    kind: constructorInvocation
-  List.generate
-    kind: constructorInvocation
 ''');
   }
 
@@ -5522,18 +5482,6 @@
 suggestions
   List
     kind: constructorInvocation
-  List.empty
-    kind: constructorInvocation
-  List.filled
-    kind: constructorInvocation
-  List.from
-    kind: constructorInvocation
-  List.generate
-    kind: constructorInvocation
-  List.of
-    kind: constructorInvocation
-  List.unmodifiable
-    kind: constructorInvocation
   XXX.fisk
     kind: constructorInvocation
 ''');