| commit | 1d0a7b28e3516d326180dbcbc42b6876302968bf | [log] [tgz] |
|---|---|---|
| author | Ömer Sinan Ağacan <omersa@google.com> | Wed Dec 20 16:39:59 2023 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Dec 20 16:39:59 2023 +0000 |
| tree | 502d347d6eb7406c456ffd3da2c666dc3eef8e3e | |
| parent | 846b23f3caa226e749e94e60e547c1e3886cb7fc [diff] |
[dart2wasm] Fix `while` statement context allocation in async functions When compiling a `while` in an `async` function, we need to allocate the context for the `while` *before* compiling the `while` condition, because any variables introduced in `while` condition will be stored in the `while` context, rather than the parent context. Instead of fixing where we allocate `while` context, we could update `CaptureFinder` to add variables in the condition to the parent context, and update `for` code generator, as it currently allocates `for` context before the conditions. I don't know if that has any advantages, for now it should be OK to update `while` code generator. `for` code generator allocates the context before the conditions and does not have this issue. Fixes #54406. Change-Id: I3c6bb7558a352d78c8f8a46a56d9bd3af68841a5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/342760 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Ömer Ağacan <omersa@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.