| commit | 1ab083ae487af531d1e28fb8fd6d50fb71aaadf9 | [log] [tgz] |
|---|---|---|
| author | Vyacheslav Egorov <vegorov@google.com> | Tue Mar 12 20:44:49 2024 +0000 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 12 20:44:49 2024 +0000 |
| tree | acb9a6cb6e56b9ad98394e36c1cd6223db81b2b9 | |
| parent | 9becf40378834e35be7daad874bce96a3b2b54a8 [diff] |
[vm/compiler] Pass arguments in registers Following the lead of unboxed calling conventions augment out backend to support passing arguments in registers on ARM, ARM64 and X64. Similar to unboxing the calling convention change only applies to functions which are invoked statically or through global dispatch table. Functions which are invoked from native code or directly invoked by dynamic call sites are not allowed to use register calling convention. This CL avoid messing too much with call instructions and instead leans on adjusting existing machinery: MoveArgument instructions corresponding to register arguments are simply detached from the graph and are processed as input constraints by the register allocator. The computation of the calling convention is centralized in `ComputeCallingConvention` in `flow_graph.cc` and is used by callees and callers. While working on this CL I have also discovered an existing bug in catch move handling (see added test runtime/tests/vm/dart/try_catch_parameter_sync_test.dart). On a large Flutter app this decreases the size of generated code by 1.8% (380Kb) and there a mixed bag of improvements in runing time, e.g. ``` build_bench (Pixel 6a) -3.536% (0.2 noise)423.16 438.68 animation_bench_close_first_frame (Pixel 6a) -3.717% (0.0 noise)253.64 263.43 rrect_contains_bench (Pixel 6a) -3.796% (0.0 noise)0.088700 0.092200 sync_star_sync_star (Pixel 6a) -5.039% (0.0 noise)2.4310 2.5600 sync_star_list (Pixel 6a) -5.329% (0.0 noise)1.0660 1.1260 velocity_tracker_bench (Pixel 6a) -5.731% (0.1 noise)62.039 65.811 sync_star_generated (Pixel 6a) -6.438% (0.0 noise)1.090 01.1650 matrix_utils_transform_point_perspective (Pixel 6a) -6.844% (0.2 noise)0.012520 0.013439 matrix_utils_transform_rect_perspective (Pixel 6a) -7.818% (0.2 noise)0.028117 0.030502 matrix_utils_transform_rect_affine -27.05% (0.7 noise) 0.017494 0.023981 ``` TEST=ci Issue https://github.com/dart-lang/sdk/issues/54955 Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-simarm_x64-try,vm-aot-linux-debug-simriscv64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-linux-product-x64-try,vm-aot-linux-release-arm64-try,vm-aot-linux-release-simarm_x64-try,vm-aot-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try Change-Id: I9a134a764666a541d4693e6ca9f6813025ecd63e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353404 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Slava Egorov <vegorov@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.