Google Git
Sign in
dart / sdk / 1aa8232308e21fed27afed791d6701ef5634ec87
commit1aa8232308e21fed27afed791d6701ef5634ec87[log] [tgz]
authorSimon Binder <oss@simonbinder.eu>Wed Oct 04 01:35:38 2023 +0000
committerCommit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 04 01:35:38 2023 +0000
tree9c31dd82bbdc5939dd77ded668963318102fb5a1
parenta46ac84206ff3e4aacfbfa15a750098af320d253 [diff]
[analyzer] Consider VarArgs in `@Native` check

Methods and functions annotated with `@FfiNative` and `@Native` are
validated to ensure their Dart signature matches the one from the
annotation.
For those functions, the lengths of the parameters is compared two
times: In `_validateCompatibleFunctionTypes` and in `_checkFfiNative`,
with the latter being responsible for emitting a more-specific error
message. However, it fails to consider that a single `VarArg` reference
in the native function type would get expanded to multiple formals in
Dart. This fixes the problem by properly expanding variadic types in
`_checkFfiNative` as well.

Closes https://github.com/dart-lang/sdk/issues/53680

Bug: 53680
Change-Id: Ifb93eba8ac9f39697dc415dc337110109449e366
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329360
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2 files changed
tree: 9c31dd82bbdc5939dd77ded668963318102fb5a1
  1. .dart_tool/
  2. .github/
  3. benchmarks/
  4. build/
  5. docs/
  6. pkg/
  7. runtime/
  8. samples/
  9. sdk/
  10. tests/
  11. third_party/
  12. tools/
  13. utils/
  14. .clang-format
  15. .gitattributes
  16. .gitconfig
  17. .gitignore
  18. .gn
  19. .mailmap
  20. .style.yapf
  21. .vpython
  22. AUTHORS
  23. BUILD.gn
  24. CHANGELOG.md
  25. codereview.settings
  26. CONTRIBUTING.md
  27. DEPS
  28. LICENSE
  29. OWNERS
  30. PATENT_GRANT
  31. PRESUBMIT.py
  32. README.dart-sdk
  33. README.md
  34. sdk.code-workspace
  35. sdk_args.gni
  36. SECURITY.md
  37. WATCHLISTS
README.md

Dart

A client-optimized language for fast apps on any platform

Dart is:

  • Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.

  • Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.

Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit dart.dev to learn more about the language, tools, and to find codelabs.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents on our wiki.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.