commit 1a8b1bfd24bf64701ad58359568f29a79b275604
author Paul Berry <paulberry@google.com> Thu Sep 13 20:38:56 2018 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> Thu Sep 13 20:38:56 2018 +0000
tree db7d8a14bb02cda4c9c5b24b3ce71e6ac3dba4e8
parent 7bc5c551cdbc71b3a79f47601dbbef6e5a979ddd

Fix test_bottom_reference_shared.

At some point this test regressed so that it no longer tested the
behavior it purported to test.  The underlying behavior is correct;
the test just had to be fixed.

Change-Id: Ia54cb205b8f1a6062f4078009d24d865d70a6bac
Reviewed-on: https://dart-review.googlesource.com/74921
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>

pkg/analyzer/test/src/summary/summarize_ast_one_phase_test.dart

diff --git a/pkg/analyzer/test/src/summary/summarize_ast_one_phase_test.dart b/pkg/analyzer/test/src/summary/summarize_ast_one_phase_test.dart
index bbab35d..5640c3f 100644
--- a/pkg/analyzer/test/src/summary/summarize_ast_one_phase_test.dart
+++ b/pkg/analyzer/test/src/summary/summarize_ast_one_phase_test.dart
@@ -18,12 +18,6 @@
     with SummaryTestCases {
   @override
   @failingTest
-  test_bottom_reference_shared() {
-    super.test_bottom_reference_shared();
-  }
-
-  @override
-  @failingTest
   test_closure_executable_with_bottom_return_type() {
     super.test_closure_executable_with_bottom_return_type();
   }

pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart

diff --git a/pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart b/pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart
index 8048ebd..cb6268c 100644
--- a/pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart
+++ b/pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart
@@ -18,12 +18,6 @@
     with SummaryTestCases {
   @override
   @failingTest
-  test_bottom_reference_shared() {
-    super.test_bottom_reference_shared();
-  }
-
-  @override
-  @failingTest
   test_closure_executable_with_imported_return_type() {
     super.test_closure_executable_with_imported_return_type();
   }

pkg/analyzer/test/src/summary/summary_common.dart

diff --git a/pkg/analyzer/test/src/summary/summary_common.dart b/pkg/analyzer/test/src/summary/summary_common.dart
index 8279c5e..1c26903 100644
--- a/pkg/analyzer/test/src/summary/summary_common.dart
+++ b/pkg/analyzer/test/src/summary/summary_common.dart
@@ -930,11 +930,13 @@
     }
     // The synthetic executables for both `x` and `y` have type `() => `Bottom`.
     // Verify that they both use the same reference to `Bottom`.
-    serializeLibraryText('int x = null; int y = null;');
+    serializeLibraryText('var x = throw null; var y = throw null;');
     EntityRef xInitializerReturnType =
         getTypeRefForSlot(findVariable('x').initializer.inferredReturnTypeSlot);
     EntityRef yInitializerReturnType =
         getTypeRefForSlot(findVariable('y').initializer.inferredReturnTypeSlot);
+    checkLinkedTypeRef(xInitializerReturnType, null, '*bottom*');
+    checkLinkedTypeRef(yInitializerReturnType, null, '*bottom*');
     expect(xInitializerReturnType.reference, yInitializerReturnType.reference);
   }