commit | 1827fcbf68bf74b2a7d13b6a189c65197bef0dd8 | [log] [tgz] |
---|---|---|
author | Tess Strickland <sstrickl@google.com> | Mon Jan 08 15:46:01 2024 +0000 |
committer | Tess Strickland <sstrickl@google.com> | Mon Jan 08 15:46:01 2024 +0000 |
tree | 011b289fe18fd0b0820c17c638270e543ac34851 | |
parent | b52dc18ff82743394edf5c4b66723d7734bd0ee5 [diff] |
[vm/compiler] Fix uses of constant indexes in LoadIndexed/StoreIndexed. Previously, CanBeImmediateIndex calculated the scaling factor for the index using Instance::ElementSizeFor. However, the LoadIndexed and StoreIndexed instructions which use this function have an index_scale_ field that is not necessarily the same as the element size for the class id. This means the displacement calculated within CanBeImmediateIndex can differ from the actual displacement calculated within ElementAddressForIntIndex, causing the bug seen by the fuzzer. This CL moves the check in CanBeImmediateIndex to a new static method Assembler::AddressCanHoldConstantIndex. In addition to the original arguments to CanBeImmediateIndex, the new static method takes an index_scale argument, so the field value can be passed appropriately. It also adds an is_external argument on X64 and IA32 to match the other architectures, since assuming a non-external typed data object could cause a register to be used in cases where it isn't necessary. TEST=vm/dart/regress_54486 Fixes: https://github.com/dart-lang/sdk/issues/54486 Change-Id: Ia553fb7da0500113b35f8d9af91a52df55437a3c Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-x64-try,vm-linux-debug-ia32-try,vm-aot-linux-debug-simarm_x64-try,vm-aot-linux-debug-simriscv64-try,vm-aot-mac-release-arm64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345002 Reviewed-by: Daco Harkes <dacoharkes@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.