commit | 0a1cad194735879bcfa60f690197a8b4cda527a4 | [log] [tgz] |
---|---|---|
author | Brian Wilkerson <brianwilkerson@google.com> | Fri Apr 19 21:38:56 2024 +0000 |
committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 19 21:38:56 2024 +0000 |
tree | 38a7209f2bb724d598027e838a24ca1c908dc48a | |
parent | 1998c87bff783f39ebc7db4e037280e8da488c8c [diff] |
Add a pass for suggesting elements that are not yet imported This CL makes 3 different changes. I'm happy to split them out into smaller CLs if you'd like me to. The first is to add the class `NotImportedCompletionPass`, which is the proposed replacement for the `NotImportedContributor`. I believe that the pass is complete, but it currently doesn't contribute any suggestions because the methods invoked by the two "operations" aren't yet implemented. That said, it does do real work in terms of searching through the libraries that aren't imported. That work is currently duplicated by the contributor, which would likely cause a performance degredation. As a result, I've commented out the invocation of the pass (but have verified that every test passes when it's not commented out). The second is to start suggesting extension members from local extensions. I'm not sure why, but prior to this CL they appear to have only been suggested by the `NotImportedContributor`, which isn't always run. I'm not sure where members from imported extensions are currently being imported, but I'll figure that out before I remove the `NotImportedContributor`. The third is to change the element being compared against when computing the inheritance distance. We were previously using the container of the element being suggested, which caused the inheritance distance to always be the same, no matter what the type hierarchy looks like. We need better tests for relevance, but I didn't add any in this CL. Change-Id: Ic82a15cab5d022f89da234a8b31bc6bca34ccb5c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363760 Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.