tree 3dfe32f7f6949e49640fe85ded24315c7ca76fd8
parent 28d08923c1729167d01053d0157de1dcc048f650
author Dmitry Stefantsov <dmitryas@google.com> 1611568407 +0000
committer commit-bot@chromium.org <commit-bot@chromium.org> 1611568407 +0000

[cfe] Don't run findTypeArgumentIssues twice

From the times where some of the type arguments should have been
reported as warnings, the procedure was run twice in two different
modes, in order to report some issues as errors and some as warnings.
This CL is a cleanup that invokes the procedure once.  Additionally, a
refactoring of the return value discipline is made: it always returns
a list and never returns null.  An empty list is returned if there are
no issues.

Change-Id: Id497216bf51f49c86517cf16a52f03da5b65b1fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180570
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>